Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support temporary AWS credentials (including AWS_SESSION_TOKEN) #275

Open
StFS opened this issue Jul 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@StFS
Copy link

StFS commented Jul 17, 2023

Describe why this change is needed

I'm trying to test the AWSPCA issuers and to do that I'm working on my local development laptop (the docker desktop k8s cluster). I was going to try using my AWS credentials to do this (since I can't apply an AWS role to resources in my own k8s cluster) but I realized that AWSPCA does not seem to support it when the AWS credentials are temporary (that is, have AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and AWS_SESSION_TOKEN).

Describe solutions and alternatives considered (optional)

It would be good if the secret referenced by the AWSPCAIssuer and AWSPCAClusterIssuer resources could include temporary AWS credentials with not only AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY but also AWS_SESSION_TOKEN.

I see here that the credentials seem to be created manually and AWS_SESSION_TOKEN is not being accounted for there. From https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/#specifying-credentials I see that it is supported so I would imagine this is simply a matter of checking for the existence of this env variable and including it if it exists.

Is there anything else you would like to add?

No response

@StFS StFS added the enhancement New feature or request label Jul 17, 2023
@bmsiegel
Copy link
Contributor

Hi @StFS , Thank you for submitting this feature request. We will review the request and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants