Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA should not overwrite library files between patch versions #1252

Closed
emmachughes opened this issue Jun 13, 2022 · 2 comments
Closed

CA should not overwrite library files between patch versions #1252

emmachughes opened this issue Jun 13, 2022 · 2 comments
Labels
Component: Content Author All issues that affect content author (sourcecode/apis/contentauthor) enhancement New feature or request

Comments

@emmachughes
Copy link
Member

When upgrading an H5P library to a new patch version, CA will overwrite files instead of generating new ones. This has given us some headaches with a caching proxy in the past (#1250).

It costs next to nothing to write new files for each patch version, and will completely sidestep any issues with browser caches, caching proxies, CDNs, etc. While we've fixed the issue on our end, we intend for Edlib to run on-premise, and it'd be nice if the caching problem just did not exist by default.

@emmachughes emmachughes added enhancement New feature or request Component: Content Author All issues that affect content author (sourcecode/apis/contentauthor) labels Jun 13, 2022
@chrieinv
Copy link
Contributor

Since the update of H5P Core and Editor, PR #2291, patch version is a part of the folder name. Patch updates no longer overwrites existing files but are written to a new folder, the old folder is then removed.

@emmachughes
Copy link
Member Author

This has been solved since ages ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Content Author All issues that affect content author (sourcecode/apis/contentauthor) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants