Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade h5p-php-library (Wrong color for h5p-actions in footer) #1142

Closed
tmkarlsen opened this issue May 5, 2022 · 10 comments · Fixed by #2159 or #2291
Closed

Upgrade h5p-php-library (Wrong color for h5p-actions in footer) #1142

tmkarlsen opened this issue May 5, 2022 · 10 comments · Fixed by #2159 or #2291
Assignees
Labels
bug Something isn't working NDLA NDLA Edlib needs triage All issues that need to be triaged by repository admins

Comments

@tmkarlsen
Copy link
Member

Incorrect color code
The footer buttons for reuse, embed, rights of use within h5p-actions should use color code: #707070 and not #999

Inspect https://ndla.no/subject:1:6f770e8e-7426-4b43-b1b1-9c12bbbcae43/topic:2:189367/topic:2:189466/resource:1:143421
vs.
https://h5p.org/presentation

@tmkarlsen tmkarlsen added bug Something isn't working NDLA NDLA Edlib needs triage All issues that need to be triaged by repository admins Needs estimation This issue needs an estimated (add comment) labels May 5, 2022
@tmkarlsen tmkarlsen added this to Edlib May 5, 2022
@tmkarlsen
Copy link
Member Author

Note: there is also a typing error within the Norwegian translation for "Use this content"/"Bruk dette innholdet" on mouse over for download.

@Kamelon7
Copy link
Contributor

Kamelon7 commented May 6, 2022

Note: there is also a typing error within the Norwegian translation for "Use this content"/"Bruk dette innholdet" on mouse over for download.

#1143 Corrected in Weblate ( "Gjenbruk dette innholded" -> "Gjenbruk dette innholdet")

@tmkarlsen tmkarlsen removed the Needs estimation This issue needs an estimated (add comment) label May 16, 2022
@tmkarlsen tmkarlsen moved this to Todo in Edlib Jun 14, 2022
@chrieinv
Copy link
Contributor

A new version of the Composer package h5p/h5p-core with the changed color is not yet available. Current version is 1.24.3.

@tmkarlsen
Copy link
Member Author

Ticket opened with question for when text release is due: h5p/h5p-php-library#125

@tmkarlsen tmkarlsen removed the status in Edlib Jun 21, 2022
@tmkarlsen
Copy link
Member Author

Impossible to know when next release is due. Would a workaround be possible/appropriate?

@Kamelon7
Copy link
Contributor

Kamelon7 commented Aug 5, 2022

Seems like it might be fixed now: h5p/h5p-php-library@ce327e0

@chrieinv
Copy link
Contributor

chrieinv commented Sep 5, 2022

Still no new version, latest tagged is 1.24.3: https://packagist.org/packages/h5p/h5p-core

@Kamelon7 Kamelon7 moved this to Backlog in Edlib Oct 18, 2022
@Kamelon7 Kamelon7 moved this from Backlog to On Hold in Edlib Oct 18, 2022
@tmkarlsen
Copy link
Member Author

@tmkarlsen tmkarlsen changed the title Wrong color for h5p-actions in footer Upgrade h5p-php-library (Wrong color for h5p-actions in footer) Jan 6, 2023
@emmachughes
Copy link
Member

The new version makes no changes that are relevant to this issue.

h5p/h5p-php-library@1.24.3...1.24.4

@tmkarlsen
Copy link
Member Author

My bad. Forgot to check the actual changes, just assumed. Should have understood that the changes were minor though...

@chrieinv chrieinv linked a pull request Mar 3, 2023 that will close this issue
@tmkarlsen tmkarlsen moved this from On Hold to In Progress in Edlib Mar 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Edlib Apr 21, 2023
@chrieinv chrieinv reopened this Apr 24, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in Edlib Apr 24, 2023
@tmkarlsen tmkarlsen moved this from Todo to In Progress in Edlib May 8, 2023
@chrieinv chrieinv linked a pull request May 15, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Edlib Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NDLA NDLA Edlib needs triage All issues that need to be triaged by repository admins
Projects
No open projects
Status: Done
4 participants