This repository has been archived by the owner on May 7, 2024. It is now read-only.
Consent updated examples #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoCrespo-ora
requested review from
gmodrogan,
amcginn,
krycunn and
kckeim
RicardoCrespo-ora
force-pushed
the
consent-examples-update
branch
3 times, most recently
from
df465b4 to
f79cae6
Compare
kckeim
suggested changes
Sep 21, 2023
There was a problem hiding this comment.
Sorry you had trouble with JSON formatting behaving on this one, @RicardoCrespo-ora.
The changes you made look okay from my perspective.
I would add some backticks around the details in the "Description" column around the parameters in the consent.md file - we have them for a few of the examples, but not all of them.
e.g.
actor=RelatedPerson/1234
->
actor=RelatedPerson/1234
Beyond that, I like this
RicardoCrespo-ora
force-pushed
the
consent-examples-update
branch
from
75420ef to
b31490c
Compare
|
Thanks for fixing stuff, @RicardoCrespo-ora. Approved from my side now |
kckeim
approved these changes
Sep 21, 2023
amcginn
approved these changes
Sep 21, 2023
lstefan4
approved these changes
Sep 22, 2023
Surya-Rnsit
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Review and corrections for ChargeItem (#976) * typo fix for CapabilityStatement (#977) * fixing URLs for scope and purpose in consent (#979) * Updated DSTU2 care-plan (#980) * Updated R4 CarePlan Resource (#981) * Updated R4 CareTeam Resource (#982) * Updated R4 CareTeam Resource (#983) * Updated DSTU2 Binary Resource (#984) * Review and Corrections for Device (#985) * Consent updated examples (#986) * Updated AllergyIntolerance R4 resource (#987) * Custom encounter search (#989) * Updated AllergyIntolerance DSTU2 resource (#990)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated examples for
Search by IdandSearch by Actorwith updated data which was previously showing outdated dataBefore
After
Before
After
Consistency with formatting in description by adding backticks
Before
After
PR Checklist