This repository has been archived by the owner on May 7, 2024. It is now read-only.
Review and corrections for ChargeItem #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoCrespo-ora
requested review from
krycunn,
SudhirPai and
SantanuBanerjee
|
ChargeItem Create "before" image is incorrect |
amcginn
suggested changes
Sep 6, 2023
Updated with correct image. Thanks |
amcginn
approved these changes
Sep 6, 2023
kckeim
approved these changes
Sep 7, 2023
krycunn
approved these changes
Sep 7, 2023
Surya-Rnsit
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Review and corrections for ChargeItem (#976) * typo fix for CapabilityStatement (#977) * fixing URLs for scope and purpose in consent (#979) * Updated DSTU2 care-plan (#980) * Updated R4 CarePlan Resource (#981) * Updated R4 CareTeam Resource (#982) * Updated R4 CareTeam Resource (#983) * Updated DSTU2 Binary Resource (#984) * Review and Corrections for Device (#985) * Consent updated examples (#986) * Updated AllergyIntolerance R4 resource (#987) * Custom encounter search (#989) * Updated AllergyIntolerance DSTU2 resource (#990)
|
After Publish |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for migrating to Oracle docs, we are reviewing and correcting any inconsistencies, typos, broken links, etc. This PR aims to correct any of the above that needs to be addressed within ChargeItem and any other information directly referenced by it.
Within Chargeitem.extension[x].extension[x].valueCodeableConcept for procedure-codes anchor link is broken, it should be https://fhir.cerner.com/millennium/r4/financial/general/charge-item/#extension
Before:
After:
When clicking Bill Code types for Chargeitem.extension[x].extension[x].valueCodeableConcept for procedure-codes, its corresponding bill type code PROCCODE is missing from the list of possible bill type codes.
Before:
After:
Chargeitem.extension[x].valueCodeableConcept for revenue-code should have the same depth as modifier code and procedure code extensions: extension[x].extension[x].valueCodeableConcept, as that is how it appears on live json responses.
Before:
After:
Chargeitem.extension[x].extension[x].valueCodeableConcept for national-drug-product has a Broken url in Details for National Drug Product: https://hl7.org/fhir/sid/ndc will redirect to https://hl7.org/fhir/http://terminology.hl7.org/5.1.0/CodeSystem-v3-ndc.html which returns a Server Error, should be https://terminology.hl7.org/5.1.0/CodeSystem-v3-ndc.html
Before:
After:
For Operations charge-item-credit, charge-item-modify, charge-item-create, their top of section anchor links don’t work properly, this is because in the table they are defined with the prefix operation-charge-item but the metadata endpoint (https://fhir-ehr-code.cerner.com/r4/ec2458f2-1e24-41c8-b71b-0e701af7583d/metadata) has them defined as #credit, #modify and #create respectively, and the anchor url is automatically defined from that. This change aims to make them match with the response from metadata so that the proper anchor url is generated.
Before
After
Create URL includes an :id, but this endpoint shouldn't have an id parameter, the example correctly omits it
Before
After
PR Checklist