Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut-site databases saved to filesystem are not backwards portable to older Python. #46

Open
cerebis opened this issue Mar 23, 2021 · 1 comment

Comments

@cerebis
Copy link
Owner

cerebis commented Mar 23, 2021

The cut-site database is stored to the filesystem using pickle. When doing so, the flag HIGHEST_PROTOCOL is used, but between Python 3.7 and 3.8 a new protocol was added (v5). Therefore files created in Py38 are not readable by Py37 and older.

I should probably specify the opposite flag or pin a protocol used by the oldest supported Python (3.7)

pickle.dump(self, cache_h, pickle.HIGHEST_PROTOCOL)

@cerebis
Copy link
Owner Author

cerebis commented Mar 23, 2021

This would just be downcast to protocol 4 -- the current default protocol and supported back to Python 3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant