Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: the --extra-build-args flag is ~ misleading when using build-webapp #716

Open
zramsay opened this issue Jan 30, 2024 · 0 comments
Open
Assignees

Comments

@zramsay
Copy link
Collaborator

zramsay commented Jan 30, 2024

For example, the website needs this env var on image build:

laconic-so build-webapp --source-repo laconic.com/ --extra-build-args "--build-arg NEXT_PUBLIC_DATOCMS_BYPASS_TYPE='local_json'"

and although this will build without erroring, buried in the output is the following:
[Warning] One or more build-args [NEXT_PUBLIC_DATOCMS_BYPASS_TYPE] were not consumed

a quick google says I should modify the Dockerfile, which wouldn't make sense since build-webapp is using an image that we don't want to modify

the solution was to modify package.json like so:

-    "build": "next build",
+    "build": "NEXT_PUBLIC_DATOCMS_BYPASS_TYPE=local_json next build",

assigning myself as a documentation issue

@zramsay zramsay self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant