Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/teuthology_api/suite: Modify how we handle Error and Success runs #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kamoltat
Copy link
Member

@kamoltat kamoltat commented Mar 13, 2024

As per As per: ceph/pulpito-ng#23
The changes includes:

  1. make suite route return
    {"run": run_details, "logs": logs, "job_count": job_count}

  2. Improve how we handle Exception by utilizing Queue from
    python multiprocessing library.

  3. Set the timeout for the process to be 180 seconds, if teuthology
    doesn't respond back within that time, then we return a Process Timeout

  4. Add .env to gitignore

Contribution Guidelines

To sign and test your commits, please refer to Contibution guidelines.

Checklist

@kamoltat kamoltat requested review from VallariAg and zmc March 13, 2024 21:57
@kamoltat kamoltat force-pushed the wip-ksirivad-suite-change branch from b26134e to 79f5529 Compare March 13, 2024 22:00
@kamoltat kamoltat force-pushed the wip-ksirivad-suite-change branch 2 times, most recently from bd56531 to 9f0b855 Compare May 9, 2024 05:37
@kamoltat kamoltat self-assigned this May 9, 2024
@kamoltat kamoltat added the enhancement Improving existing feature or logic label May 9, 2024
The changes includes:

1. make suite route return
{"run": run_details, "logs": logs, "job_count": job_count}

2. Improve how we handle Exception by utilizing Queue from
python multiprocessing library.

3. Set the timeout for the process to be 180 seconds, if teuthology
doesn't respond back within that time, then we return a Process Timeout

Signed-off-by: Kamoltat Sirivadhna <[email protected]>
@kamoltat kamoltat force-pushed the wip-ksirivad-suite-change branch from 9f0b855 to 4cb256a Compare May 10, 2024 18:18
@kamoltat
Copy link
Member Author

kamoltat commented Jun 3, 2024

#10 8.715 ERROR: Package 'teuthology-1.1.1.dev729-g861a8dcf' requires a different Python: 3.8.10 not in '>=3.10'
#10 ERROR: process "/bin/sh -c pip3 install -e ." did not complete successfully: exit code: 1
------
 > [6/7] RUN pip3 install -e .:
4.666 Collecting teuthology@ git+https://github.com/ceph/teuthology#egg=teuthology[test]
4.667   Cloning https://github.com/ceph/teuthology to /tmp/pip-install-9mdb6ecm/teuthology
4.667   Running command git clone -q https://github.com/ceph/teuthology /tmp/pip-install-9mdb6ecm/teuthology
5.797   Installing build dependencies: started
7.993   Installing build dependencies: finished with status 'done'
7.995   Getting requirements to build wheel: started
8.323   Getting requirements to build wheel: finished with status 'done'
8.327     Preparing wheel metadata: started
8.642     Preparing wheel metadata: finished with status 'done'
8.715 ERROR: Package 'teuthology-1.1.1.dev729-g861a8dcf' requires a different Python: 3.8.10 not in '>=3.10'
------
Dockerfile:24
--------------------
  22 |     WORKDIR /teuthology_api
  23 |     COPY . /teuthology_api/
  24 | >>> RUN pip3 install -e .
  25 |     RUN mkdir /archive_dir/
  26 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c pip3 install -e ." did not complete successfully: exit code: 1
Service 'teuthology_api' failed to build : Build failed****

VallariAg
VallariAg previously approved these changes Jun 13, 2024
Copy link
Member

@VallariAg VallariAg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

.gitignore Outdated
@@ -53,3 +53,6 @@ MANIFEST
.conda*/
.python-version
venv

#.env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can maybe remove this comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed with the new commit!

kamoltat added 2 commits June 17, 2024 10:04
Signed-off-by: Kamoltat Sirivadhna <[email protected]>
Added job counts to unittest.

Signed-off-by: Kamoltat Sirivadhna <[email protected]>
@kamoltat
Copy link
Member Author

Integration test failed because

of the python version issue, awaiting for
#58
to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing feature or logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants