Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minified/concatenated CSS is forced with media="screen" #4

Open
aurmil opened this issue Feb 7, 2014 · 0 comments
Open

minified/concatenated CSS is forced with media="screen" #4

aurmil opened this issue Feb 7, 2014 · 0 comments

Comments

@aurmil
Copy link

aurmil commented Feb 7, 2014

when using this module, the CSS is included with "media" attribute set to "screen"
this is done in Minify_View_Helper_HeadLink:

$this->prependStylesheet($this->view->url(array('key' => $key), 'minify_css', null, false, false)):
...
$this->prependStylesheet($this->view->url(array('key' => $key), 'concat_css', null, false, false));

so "@media print" styles in the CSS file are useless as they are not considered when printing
you should not assume what the user / dev wants to do and leave the choice or add a way to automatically determine the media type to set (eg: loop on every CSS included and set the less specific type you find)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant