Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common trait for companion generated structs #21

Open
mustermeiszer opened this issue Apr 4, 2022 · 2 comments
Open

Common trait for companion generated structs #21

mustermeiszer opened this issue Apr 4, 2022 · 2 comments
Labels
I8-enhancement An additional feature. P2-nice-to-have Issue is worth doing. Q0-trivial An issure which is similar to patching code.

Comments

@mustermeiszer
Copy link
Collaborator

Currently, the macro bundles together multiple builders in order to generate a relay-parac-chain-setup. It would be nice if at the same point the macro could implement a trait CompanionNetwork that defines all calls the macro provides for the struct anyways.
This would allow to use the trait CompanionNetwork in function/method interfaces and increases re-usability.

The changes are rather easy.

Tasks

  • [  ] Define trait in fudge primitives section
  • [ ] Alter macro to implement this trait instead of exposing methods
@mustermeiszer mustermeiszer added I8-enhancement An additional feature. P2-nice-to-have Issue is worth doing. Q0-trivial An issure which is similar to patching code. labels Apr 4, 2022
@lemunozm
Copy link
Contributor

I think this task collides with FudgeHandle from centrifuge/centrifuge-chain#1588. Ideas from FudgeHandle can be added here, and finally, remove the FudgeHandle or simplify it a lot in the centrifuge side

@lemunozm
Copy link
Contributor

This task would be much easier if first we do #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8-enhancement An additional feature. P2-nice-to-have Issue is worth doing. Q0-trivial An issure which is similar to patching code.
Projects
None yet
Development

No branches or pull requests

2 participants