Embed cluster viz #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail with a EDIT: Seems to be an issue here too: https://github.com/centre-for-humanities-computing/conspiracies/actions/runs/6537281891?pr=41 |
|
I think that is the best solution @KasperFyhn - will try to figure out if I can solve the issue with tests. |
KennethEnevoldsen
approved these changes
Oct 18, 2023
…ting/conspiracies into embed_cluster_viz
|
Så skulle tests være fikset @KasperFyhn. Undgik at downloade én af de større modeller. Det giver os lidt mindre test coverage, men det gør tilgengæld at koden kører hurtigere (og vi er less dependent på andre). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All code related to creating graphs, including clustering of entity embeddings, labeling etc., seem to be on this branch.
We might want to restructure (e.g. move core functionality out from
paper), compartmentalize and refactor a bit, but I suggest that, for now, we merge it in so as to have all code from Stine's thesis and other work on master. We can restructure along the way. What do you think, @KennethEnevoldsen?