Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search form automatically focus cursor #25

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Make search form automatically focus cursor #25

merged 1 commit into from
Oct 17, 2022

Conversation

jakewarren
Copy link
Contributor

Fixes #24

What Changed

Limitations

This introduces a new linter warning, see below. I ignored the warning because it sounds like there is some disagreement on the validity of it with the exception of some use cases 1.

src/main.js → public/build/bundle.js...
(!) Plugin svelte: A11y: Avoid using autofocus
src/SearchForm.svelte
74:                 placeholder="Search ATT&CK…"
75:                 bind:value={query}
76:                 autofocus
                    ^
77:             />
78:             <label for="searchTerms">Search ATT&amp;CK…</label>
created public/build/bundle.js in 4.9s

Footnotes

  1. https://github.com/sveltejs/svelte/issues/6629 ↩

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 67.87% // Head: 67.87% // No change to project coverage 👍

Coverage data is based on head (99f3b88) compared to base (e36c846).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files          17       17           
  Lines         579      579           
  Branches       81       81           
=======================================
  Hits          393      393           
  Misses        186      186
Impacted Files Coverage Δ
src/SearchForm.svelte 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mehaase mehaase merged commit d1ecc70 into center-for-threat-informed-defense:main Oct 17, 2022
@mehaase
Copy link
Contributor

mehaase commented Oct 17, 2022

This works great, thanks again @jakewarren!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehaase mehaase mehaase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor placement in input box
2 participants
@jakewarren @mehaase