Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add a version field to TraceConfig #213

Open
panzhongxian opened this issue Jul 31, 2019 · 0 comments
Open

Add a version field to TraceConfig #213

panzhongxian opened this issue Jul 31, 2019 · 0 comments

Comments

@panzhongxian
Copy link

panzhongxian commented Jul 31, 2019

Please add a version field to TraceConfig :

message TraceConfig {
// The global default sampler used to make decisions on span sampling.
oneof sampler {
ProbabilitySampler probability_sampler = 1;
ConstantSampler constant_sampler = 2;
RateLimitingSampler rate_limiting_sampler = 3;
}
// The global default max number of attributes per span.
int64 max_number_of_attributes = 4;
// The global default max number of annotation events per span.
int64 max_number_of_annotations = 5;
// The global default max number of message events per span.
int64 max_number_of_message_events = 6;
// The global default max number of link entries per span.
int64 max_number_of_links = 7;
}

Depending on a version filed in UpdatedLibraryConfig, Oc Agent will determine whether to send a UpdatedLibraryConfig back easily.

On library side, it's also helpful to determine whether they need to update the current libary config in there memory according to the Config response - UpdatedLibraryConfig.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant