Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

out of date GKE example #243

Open
jmhodges opened this issue Dec 3, 2019 · 0 comments
Open

out of date GKE example #243

jmhodges opened this issue Dec 3, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@jmhodges
Copy link

jmhodges commented Dec 3, 2019

The godoc GKE example are out of date. The "gke_container" type has changed to "k8s_container". I'm also not sure which of the given options are required.

(And while some of the downward API docs explains some of those env vars, it's not immediately clear that the user would have to fill in the env var for the container name in the deployment themselves, etc. But maybe that's mooted? I understand there's a scope problem here, but there's def some things that can be lost since neither the example nor the downward API docs are very explicit in how to connect them.)

@jmhodges jmhodges added the bug Something isn't working label Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant