Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] WUA compression in Title Manager does not Run with Games with DLCs or Updates in NUS Format #1404

Open
Alanzote opened this issue Nov 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Alanzote
Copy link

Alanzote commented Nov 5, 2024

Current Behavior

Using the Title Manager's compress to WUA functionality, games in the folder structure that include Updates or DLCs fail to generate WUA files without any error indication. You can see the "converting to .wua" progress bar for a split second before it vanishes completely. No .wua file is created.

Creating .wua files on games without any updates or dlcs continue to work as intended.

Tested with several local titles with different combinations of updates/dlc and only main game.

Expected Behavior

The Title Manager's compress to WUA functionality should create a .wua file that includes both the base, update and dlc.

Steps to Reproduce

(Tested on Cemu 2.2)

  • Open Title Manager
  • Select a game that contains an Update or DLC.
  • Selected "Convert to compress Wii U archive (.wua)"

System Info (Optional)

No response

Emulation Settings (Optional)

No response

Logs (Optional)

No response

@Alanzote Alanzote added the bug Something isn't working label Nov 5, 2024
@Alanzote
Copy link
Author

Alanzote commented Nov 5, 2024

Note: this is very similar, if not the same issue, to #1105. However, the issue is still present on Cemu 2.2 and even though additional comments on that issue were made recently there was no other interaction on it, so I decided to create a new issue to raise the problem again.

Additional Notes: converting the games to .wua in Cemu 2.0-54 works. Every version above it is broken.

I also did a bit of Debugging on the conversion function to see if I could figure out the issue quickly and maybe provide a pull request, however I am not familiar with Cemu enough to handle it entirely by myself quickly.

Updates and DLCs contain, while in the NUS or WUD format, Directories and Files with a Link Flag. In fscDeviceWUDC::fscDeviceOpenByPath on fscDeviceWud.cpp, files and folders with the link flag are skipped and a FSC_STATUS_FILE_NOT_FOUND is returned to fsc_open in fsc.cpp (change applied in db53f3b). This means that in the RecursivelyAddFiles and RecursivelyCountFiles functions declared on ZArchiveWriterContext at wxTitleManagerList.cpp fail in the fsc_openDirIterator function as a proper iterator is never returned by fsc_open. That stops titles from being counted and stored which fails the .wua conversion.

The base game does not contain any files/directories with the Link flag, so we are able to convert to .wua properly.

@Alanzote Alanzote changed the title [Bug] WUA compression in Title Manager does not Run with Games with DLCs or Updates [Bug] WUA compression in Title Manager does not Run with Games with DLCs or Updates in NUS Format Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant