Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Priority: Municipality Computing data issue #36

Open
cemachelen opened this issue Jan 13, 2022 · 8 comments
Open

High Priority: Municipality Computing data issue #36

cemachelen opened this issue Jan 13, 2022 · 8 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@cemachelen
Copy link
Member

https://agclimatebr.leeds.ac.uk/en/individual/2611101/ and others just say computing and never process

@cemachelen cemachelen added bug Something isn't working enhancement New feature or request labels Jan 13, 2022
@cemachelen cemachelen added this to the App demo milestone Jan 13, 2022
@cemachelen cemachelen self-assigned this Jan 13, 2022
@cemachelen
Copy link
Member Author

Dan set this up to have a mix of preprocessed and on the fly processing. There was issues with the on the fly processing which I have partially fixed on a local branch that should be able to test and implement. Dans notes suggested on the fly calculations were fast but I'll also look at just preprocessing the lot

@Murilodsv
Copy link
Collaborator

Thanks a lot, and please stick to the more realistic solution given the deadline.

@cemachelen
Copy link
Member Author

part working now. H5 files don't contain all municipalities so some still missing.

@Murilodsv
Copy link
Collaborator

Thanks! does it relates to how h5 files are being created or its an issue with the cities' shapefile? I can provide another shapefile if its needed.

@cemachelen
Copy link
Member Author

I can't quite track down why some municipalities have no datasets. The shape files look fine and now the h5 files have entries for every municipalities.

@Murilodsv
Copy link
Collaborator

Do you think if we provide preprocessed csv files for each municipality with the indexes, you could convert them into json and place in https://github.com/cemac/AgroClimatic-Monitor/tree/agr/processed/muncipalities until the release on Feb-1?

@cemachelen
Copy link
Member Author

@Murilodsv yes that could work I'll try have another little look today if I can figure out what stopping all the datasets from being incorporated into the h5.

cemachelen added a commit that referenced this issue Jan 28, 2022
these should now work for #40 #36 #15

Figures now generating correctly
h5 files should fill in now
and should be able to pick up new tifs
@Murilodsv
Copy link
Collaborator

Hi @cemachelen I just see that many individual municipalities are now working. For some, the bottom plot is still empty (e.g. Vinhedo), even though the neighbor city has indices (e.g. Valinhos). It's not critical but it should be investigated.

Also, the "generate report" button is currently sending the user to the homepage, whereas it was planned to be a download button for a csv file containing the indexes for the corresponding city. Example with dummy data:

If fixing the button it's too much for the release date, let us remove it and add it afterwards. Because there are other issues that also need attention before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants