Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using a sized type i.e., int32 or int64 for leaf index in the foundInRange method of nmt #239

Open
staheri14 opened this issue Sep 15, 2023 · 0 comments

Comments

@staheri14
Copy link
Contributor

For context please refer to the conversation on this issue #70

Originally suggested by @elias-orijtech in this comment

If you do settle on a signed type, I suggest being specific about the type (int32 or int64), or make the build fail if compiled on platforms where int is not at least 64 bits wide.

Link to the foundInRange method:

nmt/nmt.go

Line 435 in 0e219c8

func (n *NamespacedMerkleTree) foundInRange(nID namespace.ID) (found bool, startIndex int, endIndex int) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant