Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore proto generated files in codecover #222

Open
rootulp opened this issue Jul 18, 2023 · 3 comments
Open

Ignore proto generated files in codecover #222

rootulp opened this issue Jul 18, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 18, 2023 •
edited
Loading

#220 added Proto definitions to this repo. We don't need the generated proto files to be covered via unit tests so we should ignore them from the code coverage workflow that runs in this repo

Thanks for the idea @vgonkivs
@rootulp rootulp added the good first issue Good for newcomers label Jul 18, 2023
@staheri14
Copy link
Contributor

Thanks for opening this issue! Do we want to proceed with this PR or do we want to wait for this fix before merging #220?

@rootulp
Copy link
Collaborator Author

rootulp commented Jul 18, 2023

Let's proceed with #220 and tackle this issue in a follow-up PR.

@rootulp rootulp mentioned this issue Nov 15, 2024
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 15, 2024

This issue is close-able if we remove Code Coverage via #282

rootulp added a commit that referenced this issue Nov 15, 2024
@rootulp
ci: fix lint, markdown links, and build (#282)
2fb6332 
Closes #269,
#275,
#279,
#222 (b/c no longer relevant)

Note: this PR removes code coverage. If we want it back, IMO it should
be a separate workflow.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced new Makefile targets for linting and markdown link
checking.
  
- **Bug Fixes**
- Improved test reliability by ensuring correct variable capture in test
cases.

- **Documentation**
- Updated README files for clarity and accuracy, including installation
instructions and resource links.

- **Chores**
	- Updated Go version in project configuration.
- Streamlined workflow configurations for building and testing
processes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @staheri14