Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set the args when we replace the image #561

Closed
Tracked by #486
mojtaba-esk opened this issue Sep 13, 2024 · 0 comments · Fixed by #563
Closed
Tracked by #486

feat: set the args when we replace the image #561

mojtaba-esk opened this issue Sep 13, 2024 · 0 comments · Fixed by #563
Assignees
Labels
enhancement New feature or request knuu

Comments

@mojtaba-esk
Copy link
Member

Problem:

When replacing an image or switching the binary, there seems to be no straightforward way to set additional arguments, such as the --upgrade-v2-height flag, when the new image is run.

Current Behavior:

Setting arguments using SetArgs before upgrading the image should work; however, there's a status check that prevents setting args unless the instance is in either the Preparing or Committed state.

Proposal solution:

User can Stop the instance, Set the args and then Upgrade the image. To allow that to happen, we need to allow SetArgs to accept StateStopped and not only SetArgs but all funcs that user could call during that period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request knuu
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant