Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestFolder often fails due to not correct assertion #382

Closed
mojtaba-esk opened this issue May 29, 2024 · 0 comments · Fixed by #407
Closed

TestFolder often fails due to not correct assertion #382

mojtaba-esk opened this issue May 29, 2024 · 0 comments · Fixed by #407
Assignees
@tty47
Labels
knuu

Comments

@mojtaba-esk
Copy link
Member

Not sure if something has changed. Check this out: https://github.com/celestiaorg/knuu/actions/runs/9273259973/job/25512934648#step:5:152

=== NAME  TestFolder
    folder_test.go:48: 
        	Error Trace:	/home/runner/work/knuu/knuu/e2e/basic/folder_test.go:48
        	Error:      	"<!DOCTYPE html>\n<html>\n<head>\n<title>Welcome to nginx!</title>\n<style>\nhtml { color-scheme: light dark; }\nbody { width: 35em; margin: 0 auto;\nfont-family: Tahoma, Verdana, Arial, sans-serif; }\n</style>\n</head>\n<body>\n<h1>Welcome to nginx!</h1>\n<p>If you see this page, the nginx web server is successfully installed and\nworking. Further configuration is required.</p>\n\n<p>For online documentation and support please refer to\n<a href=\"[http://nginx.org/\](http://nginx.org//)">nginx.org</a>.<br/>\nCommercial support is available at\n<a href=\"[http://nginx.com/\](http://nginx.com//)">nginx.com</a>.</p>\n\n<p><em>Thank you for using nginx.</em></p>\n</body>\n</html>\n" does not contain "Hello World!"
        	Test:       	TestFolder
--- FAIL: TestFolder (40.96s)
@github-actions github-actions bot added the knuu label May 29, 2024
@tty47 tty47 self-assigned this May 30, 2024
@tty47 tty47 moved this from Todo to In Progress in Celestia DevOps/Testing May 30, 2024
@tty47 tty47 mentioned this issue May 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Celestia DevOps/Testing May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tty47 tty47

Labels
knuu
Projects
Celestia DevOps/Testing
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix TestFolder check file celestiaorg/knuu
2 participants
@mojtaba-esk @tty47