From 994378c3dab82479d248d822b22eba84ab870d2f Mon Sep 17 00:00:00 2001
From: Matthew Sevey <15232757+MSevey@users.noreply.github.com>
Date: Thu, 30 May 2024 12:00:37 -0400
Subject: [PATCH] feat: add linters (#402)

* fix: add markdownlint and resolve errors

* fix: add and resolve errors for go vet and yamllint

* fix: add and resolve errors for golangci

* feat: add additional Makefile commands

* feat(ci): add lint ci

* chore: fix mispelled name

* chore: clean up punctuation

* feat(ci): add govulncheck to make lint and lint ci

* chore: define constant for file perms
---
 .env                                          |  7 ++-
 .github/workflows/knuu_testing.yml            |  5 +-
 .github/workflows/lint.yml                    | 55 ++++++++++++++++++
 .gitignore                                    |  4 ++
 .golangci.yml                                 | 46 +++++++++++++++
 .markdownlint.yaml                            |  6 ++
 .yamllint.yml                                 |  9 +++
 CONTRIBUTING.md                               | 53 ++++++++---------
 LICENCE => LICENSE                            |  0
 Makefile                                      | 58 ++++++++++++++++++-
 README.md                                     |  4 +-
 .../adr-001-redesign-knuu-async-approach.md   | 22 +++----
 e2e/basic/file_test_image_cached_test.go      |  2 +-
 e2e/basic/files_to_volumes_cm_test.go         |  4 +-
 e2e/basic/folder_test.go                      |  3 +-
 e2e/basic/folder_test_image_cached_test.go    |  2 +-
 e2e/basic/main_test.go                        |  3 +-
 e2e/basic/probe_test.go                       |  3 +-
 e2e/basic/rbac_test.go                        |  3 +-
 pkg/builder/docker/docker.go                  |  5 +-
 pkg/builder/kaniko/kaniko.go                  |  7 ++-
 pkg/builder/kaniko/kaniko_test.go             |  5 +-
 pkg/builder/kaniko/utils_test.go              |  6 +-
 pkg/container/docker.go                       |  4 +-
 pkg/instance/bittwister.go                    |  3 +-
 pkg/instance/helper.go                        |  3 +-
 pkg/instance/instance.go                      |  4 +-
 pkg/k8s/k8s_custom_resource.go                |  2 +-
 pkg/k8s/k8s_pod.go                            |  3 +-
 pkg/k8s/types.go                              | 11 ++--
 pkg/knuu/instance_old.go                      |  5 +-
 pkg/knuu/knuu_test.go                         |  7 ++-
 pkg/minio/minio.go                            |  2 +-
 pkg/preloader/preloader.go                    |  3 +-
 pkg/system/dependencies.go                    |  3 +-
 pkg/traefik/traefik.go                        |  5 +-
 36 files changed, 280 insertions(+), 87 deletions(-)
 create mode 100644 .github/workflows/lint.yml
 create mode 100644 .gitignore
 create mode 100644 .golangci.yml
 create mode 100644 .markdownlint.yaml
 create mode 100644 .yamllint.yml
 rename LICENCE => LICENSE (100%)

diff --git a/.env b/.env
index a0ff0aab..5087a0d1 100644
--- a/.env
+++ b/.env
@@ -1,3 +1,6 @@
-KNUU_TIMEOUT=60m # The timeout for the tests
+# NOTE: this file should only contain generic environment variables as it is
+# currently part of the git history.
+
+KNUU_TIMEOUT=60m    # The timeout for the tests
 KNUU_BUILDER=docker # The builder to use for building images. docker or kubernetes
-LOG_LEVEL=info # The debug level. debug, info, warn, error
+LOG_LEVEL=info      # The debug level. debug, info, warn, error
diff --git a/.github/workflows/knuu_testing.yml b/.github/workflows/knuu_testing.yml
index 28089b09..7a2e9de5 100644
--- a/.github/workflows/knuu_testing.yml
+++ b/.github/workflows/knuu_testing.yml
@@ -2,14 +2,13 @@ name: Knuu Testing
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
   workflow_dispatch:
 
 jobs:
   test:
-
     runs-on: ubuntu-latest
 
     steps:
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
new file mode 100644
index 00000000..48683a85
--- /dev/null
+++ b/.github/workflows/lint.yml
@@ -0,0 +1,55 @@
+name: Lint
+on:
+  push:
+    branches: [main]
+  pull_request:
+  workflow_dispatch:
+  merge_group:
+
+jobs:
+  golangci-lint:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: 1.22.1
+        # This steps sets the GIT_DIFF environment variable to true
+        # if files defined in PATTERS changed
+      - uses: technote-space/get-diff-action@v6.1.2
+        with:
+          # This job will pass without running if go.mod, go.sum, and *.go
+          # wasn't modified.
+          PATTERNS: |
+            **/**.go
+            go.mod
+            go.sum
+      - uses: golangci/golangci-lint-action@v6.0.1
+        with:
+          version: latest
+          args: --timeout 10m
+          github-token: ${{ secrets.github_token }}
+        if: env.GIT_DIFF
+
+  yamllint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: celestiaorg/.github/.github/actions/yamllint@v0.4.1
+
+  markdown-lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: celestiaorg/.github/.github/actions/markdown-lint@v0.4.1
+
+  govulncheck:
+    runs-on: ubuntu-latest
+    name: Run govulncheck
+    steps:
+      - id: govulncheck
+        uses: golang/govulncheck-action@v1
+        with:
+          go-version-input: 1.22.1
+          go-package: ./...
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 00000000..26490d39
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,4 @@
+coverage.txt
+.vscode/launch.json
+*/**.html
+*.idea
diff --git a/.golangci.yml b/.golangci.yml
new file mode 100644
index 00000000..f6d91b67
--- /dev/null
+++ b/.golangci.yml
@@ -0,0 +1,46 @@
+run:
+  timeout: 5m
+  modules-download-mode: readonly
+
+linters:
+  disable:
+    # TODO: there are tons of errors for these, we need to handle in a separate PR
+    - errorlint
+    - errcheck
+    - gosec
+  enable:
+    - gofmt
+    - goimports
+    - gosimple
+    - govet
+    - ineffassign
+    - misspell
+    - revive
+    - staticcheck
+    - typecheck
+    - unconvert
+    - unused
+
+issues:
+  exclude-use-default: false
+  include:
+    - EXC0012 # EXC0012 revive: Annoying issue about not having a comment. The rare codebase has such comments
+    - EXC0014 # EXC0014 revive: Annoying issue about not having a comment. The rare codebase has such comments
+  exclude:
+    - SA1019 # TODO enable: SA 1019 staticcheck: this is being triggered by the refactor and all the deprecated code. We need to enable this once we make the breaking change official
+
+linters-settings:
+  revive:
+    rules:
+      - name: package-comments
+        disabled: true
+      - name: duplicated-imports
+        severity: warning
+      - name: exported
+        disabled: true
+        # Leaving for reference if we can enable in the future.
+        # arguments:
+        #   - disableStutteringCheck
+
+  goimports:
+    local-prefixes: github.com/celestiaorg
diff --git a/.markdownlint.yaml b/.markdownlint.yaml
new file mode 100644
index 00000000..ee333bec
--- /dev/null
+++ b/.markdownlint.yaml
@@ -0,0 +1,6 @@
+default: true
+MD010: false
+MD013: false
+MD041: false
+MD024:
+  allow_different_nesting: true
diff --git a/.yamllint.yml b/.yamllint.yml
new file mode 100644
index 00000000..cd2a9e82
--- /dev/null
+++ b/.yamllint.yml
@@ -0,0 +1,9 @@
+---
+# Built from docs https://yamllint.readthedocs.io/en/stable/configuration.html
+extends: default
+
+rules:
+  # 120 chars should be enough, but don't fail if a line is longer
+  line-length:
+    max: 120
+    level: warning
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index c8eb2561..35842760 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -10,48 +10,49 @@ If you are new to Knuu, please go through the [README](./README.md) to familiari
 
 - Have a suggestion you want to implement? Open an issue, then create a Pull Request with your implementation.
 
-- Want to resolve an issue in the repo, make a request to be assigned, and be sure to tag the issue in your PR!.
+- Want to resolve an issue in the repo, make a request to be assigned, and be sure to tag the issue in your PR!
 
 ## Contribution Workflow
 
 To contribute to Knuu, follow these steps:
 
 1. Fork the repository: Click on the 'Fork' button at the top right of this page. This will create a copy of the repository in your GitHub account.
- 
-2. Clone the forked repository to your local machine. Open your terminal and run:
 
-```bash
-git clone <forked-repository-url>
-```
+1. Clone the forked repository to your local machine. Open your terminal and run:
 
-3. Create your working branch: In the project directory, create a new branch by running the following command in your terminal:
+	```bash
+	git clone <forked-repository-url>
+	```
 
-```bash
-git checkout -b working-branch
-```
-Be sure to name your branch according to the changes you are making.
-For example: `add-missing-tests`.
+1. Create your working branch: In the project directory, create a new branch by running the following command in your terminal:
 
-4. Make your changes: Do not address multiple issues per PR. 
-For example, if you are adding a feature, it should not have bug fixes too. This is to enable the maintainers review your PR efficiently.
+	```bash
+	git checkout -b working-branch
+	```
 
-5. Commit the changes to your branch: After making the desired changes to the repo, run the following commands to commit them:
+	Be sure to name your branch according to the changes you are making.
+	For example: `add-missing-tests`.
 
-```bash
-git add .
-```
+1. Make your changes: Do not address multiple issues per PR.
+	For example, if you are adding a feature, it should not have bug fixes too. This is to enable the maintainers review your PR efficiently.
 
-```bash
-git commit -m "add an appropriate commit message"
-```
+1. Commit the changes to your branch: After making the desired changes to the repo, run the following commands to commit them:
 
-```bash
-git push origin <working-branch>
-```
+	```bash
+	git add .
+	```
 
-To ensure that your contribution is working as expected, please run `knuu-example` with your fork and working branch.
+	```bash
+	git commit -m "add an appropriate commit message"
+	```
 
-5. Create a Pull Request: Go to your forked repository on GitHub, and be sure that you are in the branch you pushed the changes to. Click on the 'Compare & pull request' button. This will open a new page where you can create your PR. Fill in the description field and click on 'Create pull request'.
+	```bash
+	git push origin <working-branch>
+	```
+
+	To ensure that your contribution is working as expected, please run `knuu-example` with your fork and working branch.
+
+1. Create a Pull Request: Go to your forked repository on GitHub, and be sure that you are in the branch you pushed the changes to. Click on the 'Compare & pull request' button. This will open a new page where you can create your PR. Fill in the description field and click on 'Create pull request'.
 Be sure to name your PR with a semantic prefix. For example, if it is a fix, it should be specified with the `fix:` prefix.
 
 Congratulations! You have successfully made a Pull Request, and your changes will be reviewed by the maintainers.
diff --git a/LICENCE b/LICENSE
similarity index 100%
rename from LICENCE
rename to LICENSE
diff --git a/Makefile b/Makefile
index 724ba306..3bdd6e7c 100644
--- a/Makefile
+++ b/Makefile
@@ -2,6 +2,62 @@ pkgs := $(shell go list ./...)
 run := .
 count := 1
 
-test: 
+## help: Show this help message
+help: Makefile
+	@echo " Choose a command run in "$(PROJECTNAME)":"
+	@sed -n 's/^##//p' $< | column -t -s ':' |  sed -e 's/^/ /'
+.PHONY: help
+
+## clean: clean testcache
+clean:
+	@echo "--> Clearing testcache"
+	@go clean --testcache
+	@rm coverage.txt
+.PHONY: clean
+
+## cover: generate to code coverage report.
+cover:
+	@echo "--> Generating Code Coverage"
+	@go install github.com/ory/go-acc@latest
+	@go-acc -o coverage.txt $(pkgs)
+.PHONY: cover
+
+## deps: Install dependencies
+deps:
+	@echo "--> Installing dependencies"
+	@go mod download
+	@go mod tidy
+.PHONY: deps
+
+## lint: Run linters golangci-lint and markdownlint.
+lint: vet
+	@echo "--> Running markdownlint"
+	@markdownlint --config .markdownlint.yaml '**/*.md'
+	@echo "--> Running yamllint"
+	@yamllint --no-warnings . -c .yamllint.yml
+	@echo "--> Running actionlint"
+	@actionlint
+	@echo "--> Running govulncheck"
+	@govulncheck ./...
+	@echo "--> Running golangci-lint"
+	@golangci-lint run
+.PHONY: lint
+
+## fmt: Run fixes for linters.
+fmt:
+	@echo "--> Formatting markdownlint"
+	@markdownlint --config .markdownlint.yaml '**/*.md' -f
+	@echo "--> Formatting go"
+	@golangci-lint run --fix
+.PHONY: fmt
+
+## vet: Run go vet
+vet: 
+	@echo "--> Running go vet"
+	@go vet $(pkgs)
+.PHONY: vet
+
+## test: Run the testsuite
+test: vet 
 	KNUU_TIMEOUT=120m go test -v $(pkgs) -run $(run) -count=$(count) -timeout 120m
 .PHONY: test
diff --git a/README.md b/README.md
index db76891b..daac61b8 100644
--- a/README.md
+++ b/README.md
@@ -204,7 +204,7 @@ In the folder `e2e`, you will find some examples of how to use the [knuu](https:
 
 ## Write Tests
 
-You can find the relevant documentation in the `pkg/knuu` package at: https://pkg.go.dev/github.com/celestiaorg/knuu
+You can find the relevant documentation in the `pkg/knuu` package at: <https://pkg.go.dev/github.com/celestiaorg/knuu>
 
 ## Run
 
@@ -256,7 +256,7 @@ See [SECURITY.md](SECURITY.md) for security and disclosure information.
 
 ## Licensing
 
-Knuu is licensed under the [Apache License 2.0](LICENSE).
+Knuu is licensed under the [Apache License 2.0](./LICENSE).
 
 <!---
 ## Contact
diff --git a/docs/architecture/adr-001-redesign-knuu-async-approach.md b/docs/architecture/adr-001-redesign-knuu-async-approach.md
index a947f9ca..46d6a7dc 100644
--- a/docs/architecture/adr-001-redesign-knuu-async-approach.md
+++ b/docs/architecture/adr-001-redesign-knuu-async-approach.md
@@ -43,21 +43,21 @@ Node Configuration:
 Playbook setup:
 
 - **After reaching height 10**:
-    - Adjust the bandwidth of **15%** of Validators to **10Mbps**.
-    - Introduce a 50ms latency to **30%** of Light DA Nodes.
-    - Add a 20ms jitter to **25%** of Full DA Nodes.
+  - Adjust the bandwidth of **15%** of Validators to **10Mbps**.
+  - Introduce a 50ms latency to **30%** of Light DA Nodes.
+  - Add a 20ms jitter to **25%** of Full DA Nodes.
 
 - **Test Duration**:
-    - Keep the test running until height **10,000**
-    - or **30 minutes**, ensuring comprehensive evaluation.
+  - Keep the test running until height **10,000**
+  - or **30 minutes**, ensuring comprehensive evaluation.
 
 - **Metrics collection**
-    - Configured traffic shape on each node
-    - Error logs of each node
-    - Time to complete the sync of DA nodes
-    - Number of missing blocks to sign
-    - Number of missing blocks to propose
-    - ...
+  - Configured traffic shape on each node
+  - Error logs of each node
+  - Time to complete the sync of DA nodes
+  - Number of missing blocks to sign
+  - Number of missing blocks to propose
+  - ...
 
 Each worker node receives this playbook and based on that decides what to do.
 The entire playbook could be written in a golang code just like what Testground does.
diff --git a/e2e/basic/file_test_image_cached_test.go b/e2e/basic/file_test_image_cached_test.go
index 748804dd..a3a6616c 100644
--- a/e2e/basic/file_test_image_cached_test.go
+++ b/e2e/basic/file_test_image_cached_test.go
@@ -35,7 +35,7 @@ func TestFileCached(t *testing.T) {
 			// adding the folder after the Commit, it will help us to use a cached image.
 			err = instance.AddFile("resources/html/index.html", "/usr/share/nginx/html/index.html", "0:0")
 			if err != nil {
-				t.Fatalf("Error adding file to '%v': %v", instanceName, err)
+				t.Errorf("Error adding file to '%v': %v", instanceName, err)
 			}
 		}(i, instance)
 	}
diff --git a/e2e/basic/files_to_volumes_cm_test.go b/e2e/basic/files_to_volumes_cm_test.go
index 803fb08a..84664b0d 100644
--- a/e2e/basic/files_to_volumes_cm_test.go
+++ b/e2e/basic/files_to_volumes_cm_test.go
@@ -24,7 +24,7 @@ func TestNoVolumesNoFiles(t *testing.T) {
 		t.Fatalf("Error creating executor: %v", err)
 	}
 
-	instanceName := fmt.Sprintf("web-1")
+	instanceName := "web-1"
 	instance, err := knuu.NewInstance(instanceName)
 	if err != nil {
 		t.Fatalf("Error creating instance '%v': %v", instanceName, err)
@@ -86,7 +86,7 @@ func TestOneVolumeNoFiles(t *testing.T) {
 		t.Fatalf("Error creating executor: %v", err)
 	}
 
-	instanceName := fmt.Sprintf("web-1")
+	instanceName := "web-1"
 	instance, err := knuu.NewInstance(instanceName)
 	if err != nil {
 		t.Fatalf("Error creating instance '%v': %v", instanceName, err)
diff --git a/e2e/basic/folder_test.go b/e2e/basic/folder_test.go
index 6227ce72..fb67341a 100644
--- a/e2e/basic/folder_test.go
+++ b/e2e/basic/folder_test.go
@@ -3,9 +3,10 @@ package basic
 import (
 	"testing"
 
-	"github.com/celestiaorg/knuu/pkg/knuu"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/celestiaorg/knuu/pkg/knuu"
 )
 
 func TestFolder(t *testing.T) {
diff --git a/e2e/basic/folder_test_image_cached_test.go b/e2e/basic/folder_test_image_cached_test.go
index f0bd041b..b88db2bf 100644
--- a/e2e/basic/folder_test_image_cached_test.go
+++ b/e2e/basic/folder_test_image_cached_test.go
@@ -37,7 +37,7 @@ func TestFolderCached(t *testing.T) {
 			// adding the folder after the Commit, it will help us to use a cached image.
 			err := instance.AddFolder("resources/html", "/usr/share/nginx/html", "0:0")
 			if err != nil {
-				t.Fatalf("Error adding file to '%v': %v", instanceName, err)
+				t.Errorf("Error adding file to '%v': %v", instanceName, err)
 			}
 		}(i, instance)
 	}
diff --git a/e2e/basic/main_test.go b/e2e/basic/main_test.go
index 5a3cb611..e09a0f50 100644
--- a/e2e/basic/main_test.go
+++ b/e2e/basic/main_test.go
@@ -4,8 +4,9 @@ import (
 	"os"
 	"testing"
 
-	"github.com/celestiaorg/knuu/pkg/knuu"
 	"github.com/sirupsen/logrus"
+
+	"github.com/celestiaorg/knuu/pkg/knuu"
 )
 
 func TestMain(m *testing.M) {
diff --git a/e2e/basic/probe_test.go b/e2e/basic/probe_test.go
index 9f07a107..800ddb6c 100644
--- a/e2e/basic/probe_test.go
+++ b/e2e/basic/probe_test.go
@@ -3,11 +3,12 @@ package basic
 import (
 	"testing"
 
-	"github.com/celestiaorg/knuu/pkg/knuu"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/util/intstr"
+
+	"github.com/celestiaorg/knuu/pkg/knuu"
 )
 
 func TestProbe(t *testing.T) {
diff --git a/e2e/basic/rbac_test.go b/e2e/basic/rbac_test.go
index 4f0a80db..ea94c784 100644
--- a/e2e/basic/rbac_test.go
+++ b/e2e/basic/rbac_test.go
@@ -3,10 +3,11 @@ package basic
 import (
 	"testing"
 
-	"github.com/celestiaorg/knuu/pkg/knuu"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	v1 "k8s.io/api/rbac/v1"
+
+	"github.com/celestiaorg/knuu/pkg/knuu"
 )
 
 func TestRBAC(t *testing.T) {
diff --git a/pkg/builder/docker/docker.go b/pkg/builder/docker/docker.go
index db7e5840..85bd08bf 100644
--- a/pkg/builder/docker/docker.go
+++ b/pkg/builder/docker/docker.go
@@ -8,12 +8,11 @@ import (
 	"os/exec"
 	"strings"
 
-	"github.com/celestiaorg/knuu/pkg/builder"
 	"github.com/sirupsen/logrus"
 	"k8s.io/client-go/kubernetes"
-)
 
-const ()
+	"github.com/celestiaorg/knuu/pkg/builder"
+)
 
 type Docker struct {
 	K8sClientset kubernetes.Interface
diff --git a/pkg/builder/kaniko/kaniko.go b/pkg/builder/kaniko/kaniko.go
index 495163da..791a0b1e 100644
--- a/pkg/builder/kaniko/kaniko.go
+++ b/pkg/builder/kaniko/kaniko.go
@@ -7,14 +7,15 @@ import (
 	"encoding/hex"
 	"fmt"
 
-	"github.com/celestiaorg/knuu/pkg/builder"
-	"github.com/celestiaorg/knuu/pkg/minio"
-	"github.com/celestiaorg/knuu/pkg/names"
 	batchv1 "k8s.io/api/batch/v1"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes"
+
+	"github.com/celestiaorg/knuu/pkg/builder"
+	"github.com/celestiaorg/knuu/pkg/minio"
+	"github.com/celestiaorg/knuu/pkg/names"
 )
 
 const (
diff --git a/pkg/builder/kaniko/kaniko_test.go b/pkg/builder/kaniko/kaniko_test.go
index f3b33e9a..cd14da83 100644
--- a/pkg/builder/kaniko/kaniko_test.go
+++ b/pkg/builder/kaniko/kaniko_test.go
@@ -6,13 +6,14 @@ import (
 	"testing"
 	"time"
 
-	"github.com/celestiaorg/knuu/pkg/builder"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	batchv1 "k8s.io/api/batch/v1"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes/fake"
+
+	"github.com/celestiaorg/knuu/pkg/builder"
 )
 
 const (
@@ -46,8 +47,8 @@ func TestKanikoBuilder(t *testing.T) {
 			logs string
 			wg   = &sync.WaitGroup{}
 		)
+		wg.Add(1)
 		go func() {
-			wg.Add(1)
 			defer wg.Done()
 			logs, err = kb.Build(context.Background(), buildOptions)
 		}()
diff --git a/pkg/builder/kaniko/utils_test.go b/pkg/builder/kaniko/utils_test.go
index 883df3eb..9e3331c3 100644
--- a/pkg/builder/kaniko/utils_test.go
+++ b/pkg/builder/kaniko/utils_test.go
@@ -13,6 +13,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+const testFilePerms = 0600
+
 func TestCreateTarGz(t *testing.T) {
 	testDir := t.TempDir()
 	expectedFiles := map[string]*struct{}{
@@ -22,10 +24,10 @@ func TestCreateTarGz(t *testing.T) {
 	}
 	for file := range expectedFiles {
 		filePath := filepath.Join(testDir, file)
-		err := os.MkdirAll(filepath.Dir(filePath), os.ModePerm)
+		err := os.MkdirAll(filepath.Dir(filePath), testFilePerms)
 		require.NoError(t, err, "Failed to create directory: %s", filepath.Dir(filePath))
 
-		err = os.WriteFile(filePath, []byte(file), os.ModePerm)
+		err = os.WriteFile(filePath, []byte(file), testFilePerms)
 		require.NoError(t, err, "Failed to create file: %s", filePath)
 	}
 
diff --git a/pkg/container/docker.go b/pkg/container/docker.go
index f8b6110c..06fcb625 100644
--- a/pkg/container/docker.go
+++ b/pkg/container/docker.go
@@ -246,13 +246,13 @@ func (f *BuilderFactory) BuildImageFromGitRepo(ctx context.Context, gitCtx build
 	return err
 }
 
-func runCommand(cmd *exec.Cmd) error {
+func runCommand(cmd *exec.Cmd) error { // nolint: unused
 	var stdout, stderr bytes.Buffer
 	cmd.Stdout = &stdout
 	cmd.Stderr = &stderr
 	err := cmd.Run()
 	if err != nil {
-		return fmt.Errorf("command failed: %s\nstdout: %s\nstderr: %s", err, stdout.String(), stderr.String())
+		return fmt.Errorf("command failed: %w\nstdout: %s\nstderr: %s", err, stdout.String(), stderr.String())
 	}
 	return nil
 }
diff --git a/pkg/instance/bittwister.go b/pkg/instance/bittwister.go
index d45bc55a..2266f324 100644
--- a/pkg/instance/bittwister.go
+++ b/pkg/instance/bittwister.go
@@ -4,8 +4,9 @@ import (
 	"context"
 	"time"
 
-	"github.com/celestiaorg/bittwister/sdk"
 	"github.com/sirupsen/logrus"
+
+	"github.com/celestiaorg/bittwister/sdk"
 )
 
 const (
diff --git a/pkg/instance/helper.go b/pkg/instance/helper.go
index 14fc499f..66cd0aea 100644
--- a/pkg/instance/helper.go
+++ b/pkg/instance/helper.go
@@ -12,9 +12,10 @@ import (
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
 
-	"github.com/celestiaorg/knuu/pkg/k8s"
 	"github.com/google/uuid"
 	"github.com/sirupsen/logrus"
+
+	"github.com/celestiaorg/knuu/pkg/k8s"
 )
 
 // getImageRegistry returns the name of the temporary image registry
diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go
index 36b054bd..69eb1bac 100644
--- a/pkg/instance/instance.go
+++ b/pkg/instance/instance.go
@@ -1089,13 +1089,13 @@ func (i *Instance) WaitInstanceIsRunning(ctx context.Context) error {
 		return ErrWaitingForInstanceNotAllowed.WithParams(i.state.String())
 	}
 	timeout := time.After(1 * time.Minute)
-	tick := time.Tick(1 * time.Second)
+	tick := time.NewTicker(1 * time.Second)
 
 	for {
 		select {
 		case <-timeout:
 			return ErrWaitingForInstanceTimeout.WithParams(i.k8sName)
-		case <-tick:
+		case <-tick.C:
 			running, err := i.IsRunning(ctx)
 			if err != nil {
 				return ErrCheckingIfInstanceRunning.WithParams(i.k8sName).Wrap(err)
diff --git a/pkg/k8s/k8s_custom_resource.go b/pkg/k8s/k8s_custom_resource.go
index b7c41411..6634d9eb 100644
--- a/pkg/k8s/k8s_custom_resource.go
+++ b/pkg/k8s/k8s_custom_resource.go
@@ -46,7 +46,7 @@ func (c *Client) CustomResourceDefinitionExists(ctx context.Context, gvr *schema
 
 	resourceExists := false
 	for _, resource := range resourceList.APIResources {
-		if strings.ToLower(resource.Kind) == strings.ToLower(gvr.Resource) {
+		if strings.EqualFold(resource.Kind, gvr.Resource) {
 			resourceExists = true
 			break
 		}
diff --git a/pkg/k8s/k8s_pod.go b/pkg/k8s/k8s_pod.go
index f6144fa3..f169d0ae 100644
--- a/pkg/k8s/k8s_pod.go
+++ b/pkg/k8s/k8s_pod.go
@@ -106,6 +106,7 @@ func (c *Client) ReplacePodWithGracePeriod(ctx context.Context, podConfig PodCon
 	}
 
 	// Wait for the pod to be fully deleted
+PodCheckLoop:
 	for {
 		select {
 		case <-ctx.Done():
@@ -118,7 +119,7 @@ func (c *Client) ReplacePodWithGracePeriod(ctx context.Context, podConfig PodCon
 					logrus.Debugf("Pod %s successfully deleted", podConfig.Name)
 					goto DeployPod
 				}
-				break
+				break PodCheckLoop
 			}
 		}
 	}
diff --git a/pkg/k8s/types.go b/pkg/k8s/types.go
index f33e1791..586895f5 100644
--- a/pkg/k8s/types.go
+++ b/pkg/k8s/types.go
@@ -5,7 +5,6 @@ import (
 
 	appv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
-	v1 "k8s.io/api/core/v1"
 	netv1 "k8s.io/api/networking/v1"
 	rbacv1 "k8s.io/api/rbac/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
@@ -18,16 +17,16 @@ type KubeManager interface {
 	Clientset() *kubernetes.Clientset
 	CreateClusterRole(ctx context.Context, name string, labels map[string]string, policyRules []rbacv1.PolicyRule) error
 	CreateClusterRoleBinding(ctx context.Context, name string, labels map[string]string, clusterRole, serviceAccount string) error
-	CreateConfigMap(ctx context.Context, name string, labels, data map[string]string) (*v1.ConfigMap, error)
+	CreateConfigMap(ctx context.Context, name string, labels, data map[string]string) (*corev1.ConfigMap, error)
 	CreateCustomResource(ctx context.Context, name string, gvr *schema.GroupVersionResource, obj *map[string]interface{}) error
-	CreateDaemonSet(ctx context.Context, name string, labels map[string]string, initContainers []v1.Container, containers []v1.Container) (*appv1.DaemonSet, error)
+	CreateDaemonSet(ctx context.Context, name string, labels map[string]string, initContainers []corev1.Container, containers []corev1.Container) (*appv1.DaemonSet, error)
 	CreateNamespace(ctx context.Context, name string) error
 	CreateNetworkPolicy(ctx context.Context, name string, selectorMap, ingressSelectorMap, egressSelectorMap map[string]string) error
 	CreatePersistentVolumeClaim(ctx context.Context, name string, labels map[string]string, size resource.Quantity) error
 	CreateReplicaSet(ctx context.Context, rsConfig ReplicaSetConfig, init bool) (*appv1.ReplicaSet, error)
 	CreateRole(ctx context.Context, name string, labels map[string]string, policyRules []rbacv1.PolicyRule) error
 	CreateRoleBinding(ctx context.Context, name string, labels map[string]string, role, serviceAccount string) error
-	CreateService(ctx context.Context, name string, labels, selectorMap map[string]string, portsTCP, portsUDP []int) (*v1.Service, error)
+	CreateService(ctx context.Context, name string, labels, selectorMap map[string]string, portsTCP, portsUDP []int) (*corev1.Service, error)
 	CreateServiceAccount(ctx context.Context, name string, labels map[string]string) error
 	CustomResourceDefinitionExists(ctx context.Context, gvr *schema.GroupVersionResource) bool
 	DaemonSetExists(ctx context.Context, name string) (bool, error)
@@ -61,7 +60,7 @@ type KubeManager interface {
 	NetworkPolicyExists(ctx context.Context, name string) bool
 	NewFile(source, dest string) *File
 	NewVolume(path, size string, owner int64) *Volume
-	PatchService(ctx context.Context, name string, labels, selectorMap map[string]string, portsTCP, portsUDP []int) (*v1.Service, error)
+	PatchService(ctx context.Context, name string, labels, selectorMap map[string]string, portsTCP, portsUDP []int) (*corev1.Service, error)
 	PortForwardPod(ctx context.Context, podName string, localPort, remotePort int) error
 	ReplicaSetExists(ctx context.Context, name string) (bool, error)
 	ReplacePod(ctx context.Context, podConfig PodConfig) (*corev1.Pod, error)
@@ -73,7 +72,7 @@ type KubeManager interface {
 	getPod(ctx context.Context, name string) (*corev1.Pod, error)
 	getReplicaSet(ctx context.Context, name string) (*appv1.ReplicaSet, error)
 	ConfigMapExists(ctx context.Context, name string) (bool, error)
-	UpdateDaemonSet(ctx context.Context, name string, labels map[string]string, initContainers []v1.Container, containers []v1.Container) (*appv1.DaemonSet, error)
+	UpdateDaemonSet(ctx context.Context, name string, labels map[string]string, initContainers []corev1.Container, containers []corev1.Container) (*appv1.DaemonSet, error)
 	WaitForDeployment(ctx context.Context, name string) error
 	WaitForService(ctx context.Context, name string) error
 }
diff --git a/pkg/knuu/instance_old.go b/pkg/knuu/instance_old.go
index ee0b0261..11fa2618 100644
--- a/pkg/knuu/instance_old.go
+++ b/pkg/knuu/instance_old.go
@@ -12,11 +12,12 @@ import (
 	"errors"
 	"io"
 
-	"github.com/celestiaorg/knuu/pkg/builder"
-	"github.com/celestiaorg/knuu/pkg/instance"
 	v1 "k8s.io/api/core/v1"
 	rbacv1 "k8s.io/api/rbac/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+
+	"github.com/celestiaorg/knuu/pkg/builder"
+	"github.com/celestiaorg/knuu/pkg/instance"
 )
 
 type Instance struct {
diff --git a/pkg/knuu/knuu_test.go b/pkg/knuu/knuu_test.go
index e1232e40..35413ebf 100644
--- a/pkg/knuu/knuu_test.go
+++ b/pkg/knuu/knuu_test.go
@@ -5,15 +5,16 @@ import (
 	"testing"
 	"time"
 
-	"github.com/celestiaorg/knuu/pkg/builder/kaniko"
-	"github.com/celestiaorg/knuu/pkg/k8s"
-	"github.com/celestiaorg/knuu/pkg/minio"
 	"github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
 	appv1 "k8s.io/api/apps/v1"
 	rbacv1 "k8s.io/api/rbac/v1"
 	"k8s.io/client-go/kubernetes"
+
+	"github.com/celestiaorg/knuu/pkg/builder/kaniko"
+	"github.com/celestiaorg/knuu/pkg/k8s"
+	"github.com/celestiaorg/knuu/pkg/minio"
 )
 
 const (
diff --git a/pkg/minio/minio.go b/pkg/minio/minio.go
index ac9d909a..3f5a829f 100644
--- a/pkg/minio/minio.go
+++ b/pkg/minio/minio.go
@@ -234,7 +234,7 @@ func (m *Minio) GetMinioURL(ctx context.Context, minioFilePath, bucketName strin
 	}
 
 	// Set the expiration time for the URL (e.g., 24h from now)
-	expiration := time.Duration(24 * time.Hour)
+	expiration := 24 * time.Hour
 
 	// Generate a presigned URL for the object
 	presignedURL, err := minioClient.PresignedGetObject(ctx, bucketName, minioFilePath, expiration, nil)
diff --git a/pkg/preloader/preloader.go b/pkg/preloader/preloader.go
index 78fe9332..a8dd9de3 100644
--- a/pkg/preloader/preloader.go
+++ b/pkg/preloader/preloader.go
@@ -4,9 +4,10 @@ import (
 	"context"
 	"fmt"
 
+	v1 "k8s.io/api/core/v1"
+
 	"github.com/celestiaorg/knuu/pkg/names"
 	"github.com/celestiaorg/knuu/pkg/system"
-	v1 "k8s.io/api/core/v1"
 )
 
 const (
diff --git a/pkg/system/dependencies.go b/pkg/system/dependencies.go
index 0b28f732..8ca58db8 100644
--- a/pkg/system/dependencies.go
+++ b/pkg/system/dependencies.go
@@ -1,11 +1,12 @@
 package system
 
 import (
+	"github.com/sirupsen/logrus"
+
 	"github.com/celestiaorg/knuu/pkg/builder"
 	"github.com/celestiaorg/knuu/pkg/k8s"
 	"github.com/celestiaorg/knuu/pkg/minio"
 	"github.com/celestiaorg/knuu/pkg/traefik"
-	"github.com/sirupsen/logrus"
 )
 
 type SystemDependencies struct {
diff --git a/pkg/traefik/traefik.go b/pkg/traefik/traefik.go
index 55da22b1..3749f2a8 100644
--- a/pkg/traefik/traefik.go
+++ b/pkg/traefik/traefik.go
@@ -5,8 +5,6 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/celestiaorg/knuu/pkg/k8s"
-	"github.com/celestiaorg/knuu/pkg/names"
 	"github.com/sirupsen/logrus"
 	appsv1 "k8s.io/api/apps/v1"
 	v1 "k8s.io/api/core/v1"
@@ -17,6 +15,9 @@ import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/apimachinery/pkg/util/intstr"
 	"k8s.io/utils/ptr"
+
+	"github.com/celestiaorg/knuu/pkg/k8s"
+	"github.com/celestiaorg/knuu/pkg/names"
 )
 
 const (