feat!: adds support for gRPC streaming and removes dependency on RPC #3915
+479
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
|
PR still not fully ready, some tests are still failing. but would be good to get initial opinion + if someone can see if it's providing you with any performance increase |
rach-id
commented
Nov 4, 2024
rach-id
commented
Nov 5, 2024
nodebuilder/core/module.go
Outdated
Comment on lines
79
to
84
| fx.OnStart(func(_ context.Context, client core.Client) error { | ||
| return client.Start() | ||
| }), | ||
| fx.OnStop(func(_ context.Context, client core.Client) error { | ||
| return client.Stop() | ||
| }), |
There was a problem hiding this comment.
[note for reviewers]
with the new implementation, the gRPC connection is started when creating the client instead of waiting until we call Start()
There was a problem hiding this comment.
Yes but we also need to close conn when node stops.
rach-id
commented
Nov 5, 2024
rach-id
commented
Nov 5, 2024
go.mod
Outdated
| github.com/filecoin-project/dagstore => github.com/celestiaorg/dagstore v0.0.0-20230824094345-537c012aa403 | ||
| github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | ||
| // broken goleveldb needs to be replaced for the cosmos-sdk and celestia-app | ||
| github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | ||
| github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.43.0-tm-v0.34.35 | ||
| github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.43.0-tm-v0.34.35.0.20241104132041-3d2b32b7ddf2 |
There was a problem hiding this comment.
[note for reviewers]
will be updated once we merge the PRs and make release
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3915 +/- ##
==========================================
+ Coverage 44.83% 45.34% +0.50%
==========================================
Files 265 308 +43
Lines 14620 22089 +7469
==========================================
+ Hits 6555 10016 +3461
- Misses 7313 10980 +3667
- Partials 752 1093 +341 ☔ View full report in Codecov by Sentry. |
…port-grpc-endpoints
cristaloleg
reviewed
Nov 27, 2024
cristaloleg
reviewed
Nov 27, 2024
renaynay
reviewed
Nov 27, 2024
renaynay
reviewed
Nov 27, 2024
# Conflicts: # go.mod # go.sum
# Conflicts: # core/eds.go # go.mod # go.sum
vgonkivs
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Celestia-node part of celestiaorg/celestia-core#1513