Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header: Consider requiring 2/3+1 valset overlap for non-adjacent verification #3965

Open
renaynay opened this issue Nov 27, 2024 · 2 comments
Labels
area:header Extended header

Comments

@renaynay
Copy link
Member

Currently we use the default setting from tendermint light client library (which is 1/3+1 valset overlap requirement). After speaking a bit about it with @cmwaters, there's no real "downside" to requiring 2/3rds overlap to verify a non-adjacent sync target. The only downside I could see is "more frequent" failure for non-adjacent verification --> bifurcated sync target verification --> and if that doesn't work, subjective re-initialisation. To know exactly how much more frequent, we need to see how much churn there is in the validator set within the weak subjectivity window.

@renaynay renaynay added the area:header Extended header label Nov 27, 2024
@cmwaters
Copy link
Contributor

bifurcation should always work, if there is more than 1/3 change in a single block, it will eventually bifurcate to that adjacent block and then it should fallback to using adjacent verification

@renaynay
Copy link
Member Author

*bifurcation should always work if the header is a valid part of the chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header
Projects
None yet
Development

No branches or pull requests

2 participants