Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Migrate to go-square types #3770

Open
cmwaters opened this issue Sep 24, 2024 · 0 comments · May be fixed by #3782
Open

[Feature Request]: Migrate to go-square types #3770

cmwaters opened this issue Sep 24, 2024 · 0 comments · May be fixed by #3782
Assignees
Labels
external Issues created by non node team members needs:triage

Comments

@cmwaters
Copy link
Contributor

Implementation ideas

We have a new v2 go square package which is intended to unify the types across both the celestia-node and celestia-app package. As part of preparing to upgrade to v3, we need to migrate the existing core types like:

  • Share
  • Namespace
  • Blob
  • BlobTx
  • Square

to the new types specified in this repo.

I'm unfamiliar of how this may break the APIs for celestia-node.

V2 of go-square is backwards compatible from the square construction perspective. This means that all squares constructed using the v1 and v2 of the application can be constructed with the v2 go-square. The construction is not forwards compatible. v3 of celestia-app can produce a square (using v2 of go-square) which is different to v1 of go-square.

@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Sep 24, 2024
@vgonkivs vgonkivs self-assigned this Sep 24, 2024
@cristaloleg cristaloleg linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members needs:triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants