Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: /submit_pfb uses namespace ID without version byte #2292

Closed
tuxcanfly opened this issue May 31, 2023 · 5 comments
Closed

gateway: /submit_pfb uses namespace ID without version byte #2292

tuxcanfly opened this issue May 31, 2023 · 5 comments
Labels
bug Something isn't working external Issues created by non node team members

Comments

@tuxcanfly
Copy link
Contributor

tuxcanfly commented May 31, 2023

Celestia Node version

v0.11.0-rc1

OS

darwin/arm64

Install tools

go-cnc v0.3.0

Others

No response

Steps to reproduce it

Submit PFB to the endpoint http://127.0.0.1:26657/submit_pfb

Expected result

PFB is accepted and transaction data is returned

Actual result

Unable to submit PFB to the endpoint, as it errors

Relevant log output

unsupported namespace id length: id [...] must be 28 bytes but it was 29 bytes

https://github.com/celestiaorg/go-cnc/actions/runs/5136913174/jobs/9244284199?pr=55#step:5:80

Notes

cc @rootulp

@tuxcanfly tuxcanfly added the bug Something isn't working label May 31, 2023
@github-actions github-actions bot added the external Issues created by non node team members label May 31, 2023
@Wondertan Wondertan changed the title rpc: /submit_pfb uses namespace ID without version byte gateway: /submit_pfb uses namespace ID without version byte Jun 1, 2023
@Wondertan
Copy link
Member

@tuxcanfly, JFYI, it's a gateway issue, not rpc

@Wondertan
Copy link
Member

However, this does not seem to be an actual problem on celestia-node side:

  • I double-checked the code, and we don't set any restrictions on the size
  • The linked failed test is in go-cnc, not the node.

Considering these two facts, I am closing the issue.

@Wondertan Wondertan closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@rootulp
Copy link
Contributor

rootulp commented Jun 1, 2023

I think the celestia-node RPC* is broken b/c celestiaorg/docs#781 (comment) so will wait until that is resolved.

Also related #2300 and #2301

@Wondertan
Copy link
Member

@rootulp, Josh meant RPC is broken, not the gateway

@rootulp
Copy link
Contributor

rootulp commented Jun 2, 2023

Fixed comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues created by non node team members
Projects
None yet
Development

No branches or pull requests

3 participants