-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: release-guide link to release notes #3989
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs/maintainers/release-guide.md (2)
34-34
: LGTM: Valuable addition of Upgrade Notice section.This requirement ensures that critical information is prominently displayed in the release notes, which is excellent for improving documentation as per the PR objectives.
Consider adding a brief example or template of what should be included in the Upgrade Notice section to provide even more clarity for maintainers.
35-35
: LGTM: Excellent addition of link to centralized release notes.This change directly addresses the PR objectives by providing a link to comprehensive release notes, which is crucial for documenting breaking changes and improvements.
To improve markdown formatting and resolve the linter warning, consider wrapping the URL in angle brackets:
- The release notes section should contain a link to <https://github.com/celestiaorg/celestia-app/blob/main/docs/release-notes/release-notes.md> where we capture breaking changes🧰 Tools
🪛 Markdownlint
35-35: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- docs/maintainers/release-guide.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
docs/maintainers/release-guide.md
35-35: null
Bare URL used(MD034, no-bare-urls)
🔇 Additional comments (2)
docs/maintainers/release-guide.md (2)
33-33
: LGTM: Clear instruction for testnet release versioning.This addition provides clear guidance for versioning testnet releases, which aligns well with the PR objectives of improving the release guide documentation.
33-35
: Overall: Excellent improvements to the release guide.These changes significantly enhance the release process documentation, addressing the PR objectives effectively. They provide clear instructions for versioning, highlight important upgrade information, and ensure comprehensive documentation of breaking changes. These improvements will greatly benefit maintainers and users of the Celestia application.
🧰 Tools
🪛 Markdownlint
35-35: null
Bare URL used(MD034, no-bare-urls)
Closes #3913