Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: release-guide link to release notes #3989

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 17, 2024

Closes #3913

@rootulp rootulp self-assigned this Oct 17, 2024
@rootulp rootulp requested review from liamsi and a team as code owners October 17, 2024 18:31
Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

📝 Walkthrough

Walkthrough

The pull request updates the release-guide.md document with new guidelines for the release process aimed at maintainers. Key changes include specifying version tag suffixes for testnet releases, requiring an Upgrade Notice section in release notes, and mandating a link to the release notes document that captures breaking changes.

Changes

File Change Summary
docs/maintainers/release-guide.md Updated to include guidelines for version suffixes for testnet releases, added requirement for an Upgrade Notice in release notes, and mandated a link to the release notes document.

Assessment against linked issues

Objective Addressed Explanation
Add link to release notes for subsequent v2.x.x releases (3913)

Possibly related PRs

  • docs: fix upgrade doc link #3888: This PR updates the release notes document, which is directly related to the changes made in the main PR regarding the inclusion of links to release notes and upgrade notices.

Suggested labels

external

Suggested reviewers

  • cmwaters
  • ninabarbakadze
  • staheri14
  • evan-forbes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
docs/maintainers/release-guide.md (2)

34-34: LGTM: Valuable addition of Upgrade Notice section.

This requirement ensures that critical information is prominently displayed in the release notes, which is excellent for improving documentation as per the PR objectives.

Consider adding a brief example or template of what should be included in the Upgrade Notice section to provide even more clarity for maintainers.


35-35: LGTM: Excellent addition of link to centralized release notes.

This change directly addresses the PR objectives by providing a link to comprehensive release notes, which is crucial for documenting breaking changes and improvements.

To improve markdown formatting and resolve the linter warning, consider wrapping the URL in angle brackets:

- The release notes section should contain a link to <https://github.com/celestiaorg/celestia-app/blob/main/docs/release-notes/release-notes.md> where we capture breaking changes
🧰 Tools
🪛 Markdownlint

35-35: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 2507aaf and 0a16a95.

📒 Files selected for processing (1)
  • docs/maintainers/release-guide.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
docs/maintainers/release-guide.md

35-35: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (2)
docs/maintainers/release-guide.md (2)

33-33: LGTM: Clear instruction for testnet release versioning.

This addition provides clear guidance for versioning testnet releases, which aligns well with the PR objectives of improving the release guide documentation.


33-35: Overall: Excellent improvements to the release guide.

These changes significantly enhance the release process documentation, addressing the PR objectives effectively. They provide clear instructions for versioning, highlight important upgrade information, and ensure comprehensive documentation of breaking changes. These improvements will greatly benefit maintainers and users of the Celestia application.

🧰 Tools
🪛 Markdownlint

35-35: null
Bare URL used

(MD034, no-bare-urls)

@rootulp rootulp enabled auto-merge (squash) October 18, 2024 20:47
@rootulp rootulp merged commit 0b3c516 into main Oct 21, 2024
34 checks passed
@rootulp rootulp deleted the rp/release-guide-link-to-release-notes branch October 21, 2024 09:00
rach-id pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to release notes for subsequent v2.x.x releases
3 participants