Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version DefaultUpgradeHeightDelay #3979

Closed
evan-forbes opened this issue Oct 16, 2024 · 1 comment
Closed

Version DefaultUpgradeHeightDelay #3979

evan-forbes opened this issue Oct 16, 2024 · 1 comment
Assignees
@staheri14
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules nice to have item is not blocking or required. WS: V3 3️⃣ item is directly relevant to the v3 hardfork

Comments

@evan-forbes
Copy link
Member

In order to keep roughly a week delay, we should version the DefaultUpgradeHeightDelay. To close this issue, version DefaultUpgradeHeightDelay. Ideally, such a change would get into v3 so that when upgrading to v4, the delay would be the same.
@evan-forbes evan-forbes added consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules nice to have item is not blocking or required. WS: V3 3️⃣ item is directly relevant to the v3 hardfork labels Oct 16, 2024
@evan-forbes evan-forbes mentioned this issue Oct 16, 2024
Merged
evan-forbes added a commit that referenced this issue Oct 16, 2024
@evan-forbes
feat!: version UpgradeHeightDelay (#3980)
d969f68 
## Overview

closes #3978 #3979

this is just a nice to have for v3. If we're worried about this causing
issues at all, we should just postpone this imo.
@rootulp rootulp mentioned this issue Nov 25, 2024
Open
@rootulp
Copy link
Collaborator

rootulp commented Nov 25, 2024

This appears to have been done via #3882

Please re-open if I'm mistaken @evan-forbes @staheri14

@rootulp rootulp closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules nice to have item is not blocking or required. WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rootulp @staheri14 @evan-forbes