-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version gas schedule variables #3404
Comments
Clarifying question: do you mean all params or just the params related to the gas scheduler? I'm a fan of moving governance modifiable params to versioned constants. IMO this likely warrants a CIP b/c it's moving scope for modifying these params from token governance to the CIP process. I think this will be a relatively small code change but it will take time to get through the CIP process so I think it's unlikely to get finalized prior to our scheduled feature freeze on May 15th for v2. |
Just related to the gas scheduler. I thought I had specified it but I must have missed it. Thanks for catching it. |
The two params that are being considered:
|
Can we have this planned for v3? @evan-forbes |
We would first need to write a CIP on this |
## Overview - Fixes #3404 - Fixes #3748 - Fixes #3762 --------- Co-authored-by: Rootul P <[email protected]>
For posterity: |
All on-chain governance modifiable parameters associated with the gas scheduler (i.e. GasCostPayForBlobs) should become versioned parameters i.e. they can only change with a hard fork upgrade.
The reason is to help clients who are submitting transactions make it easier to estimate the gas (as it won't fluctuate from block to block and you won't need additional queries for these values - they can be hardcoded into your estimator)
Context: #3011 (comment)_
Acceptance Criteria
The text was updated successfully, but these errors were encountered: