Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code improvements in qgb contracts #244

Open
dalmirel opened this issue Oct 25, 2023 · 0 comments
Open

Minor code improvements in qgb contracts #244

dalmirel opened this issue Oct 25, 2023 · 0 comments
Labels

Comments

@dalmirel
Copy link

Involved artifacts

Description

The minor code improvements listed within this finding do not pose a security threat nor do they introduce an issue. The suggestions are shared to improve the code readability, keep consistency, optimize, and improve logging:

  • Doubled the word “root“ within the comment.
  • A comment that validators that did not signed the attestation will have nil value in sigs here should be added to improve readability of code, because looking at this part of the code it can be only assumed that all the validators have to sign the data. There is a similar comment in checkValidatorSignatures.
  • Wrong comment placements (should be after the following if blocks):

Problem Scenarios

Findings listed above could not introduce any issues, they are suggestions for code improvements.

Recommendation

As described above.

@rach-id rach-id added the audit label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants