You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The minor code improvements listed within this finding do not pose a security threat nor do they introduce an issue. The suggestions are shared to improve the code readability, keep consistency, optimize, and improve logging:
A comment that validators that did not signed the attestation will have nil value in sigs here should be added to improve readability of code, because looking at this part of the code it can be only assumed that all the validators have to sign the data. There is a similar comment in checkValidatorSignatures.
Wrong comment placements (should be after the following if blocks):
Involved artifacts
Description
The minor code improvements listed within this finding do not pose a security threat nor do they introduce an issue. The suggestions are shared to improve the code readability, keep consistency, optimize, and improve logging:
Problem Scenarios
Findings listed above could not introduce any issues, they are suggestions for code improvements.
Recommendation
As described above.
The text was updated successfully, but these errors were encountered: