Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code simplification #242

Open
andrijamitrovic23 opened this issue Oct 25, 2023 · 0 comments
Open

Code simplification #242

andrijamitrovic23 opened this issue Oct 25, 2023 · 0 comments
Labels

Comments

@andrijamitrovic23
Copy link

Involved artifacts

Description
NMT assumes that the leafs are ordered by namespace. This assumption is not used here as it is used in the rest of the code.

Problem Scenarios
Findings listed above could not introduce any issues, they are suggestions for code improvements.

Recommendation
Calculated minimum namespace is always equal to the left minimum namespace so it could be calculated as follows:
Namespace memory min = l.min

This is how it is done in the nmt library that is used in Celestia:
minNs := leftMinNs

@rach-id rach-id added the audit label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants