Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate, test and demo cancelPromise #50

Open
cefn opened this issue Dec 3, 2023 · 0 comments
Open

Integrate, test and demo cancelPromise #50

cefn opened this issue Dec 3, 2023 · 0 comments

Comments

@cefn
Copy link
Owner

cefn commented Dec 3, 2023

Currently the cancelPromise mechanism is there (in that cancelPromise options are provided and the value is passed in the invocation of a job.

The cancelPromise mechanism should be used and tested for two scenarios...

  • The overall schedule is halted by the requester resolving the CancelPromise
  • A timeout has expired, and the launched promise can therefore afford to give up.

However currently...

  • Internal promises aren't co-wired to the cancelPromise (e.g. queue promises, launchesFinalized.promise, settlementsFinalized.promise)
  • The timeout mechanism doesn't pass a job-invocation-specific cancelPromise (that composes with the global cancelPromise) meaning jobs will continue executing in the background and their results just ignored even when their specific timeout has expired
  • There are no tests for the approach
  • There are no demos of the approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant