forked from ponty/arduino-rtttl-player
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in pop_byte #5
Comments
Strictly speaking the assembly produced by the current version of the code is likely the same as the assembly which would be created by the explicit return (since get_byte puts everything in the right location and the caller function pop_byte ends). Still worth fixing IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Your pop_byte routine reads as follows:
There is no return here.
Normally I would submit a pull request but if you see the other issue I filed (with the name change) then you can imagine that my pull request would look very odd. Pretty simple bug and fix.
The text was updated successfully, but these errors were encountered: