Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting for biorxiv short-circuits #1

Open
jtpdowns opened this issue Mar 2, 2020 · 0 comments
Open

Formatting for biorxiv short-circuits #1

jtpdowns opened this issue Mar 2, 2020 · 0 comments

Comments

@jtpdowns
Copy link

jtpdowns commented Mar 2, 2020

Hello! I've been using this library for a while, and I just started testing some functionality I hadn't needed when I noticed that the biorxiv id doesn't currently work as described on the README. If I enter an id expression with a colon in it like "biorxiv:570689", I get an error because the code ends up constructing a DOI with colon in it. I think this is because the regular expression 'biorxiv':'^biorxiv ?|^biorxiv:' in the tests always matches the first expression before the second one. It might just work to swap the two cases in the regex.
scnerd pushed a commit to scnerd/refid2bib that referenced this issue Jul 14, 2020
Fixes issue ceesem#1, a break in biorxiv id's that are given directly…
4252cb8 
…. Fixes some instabilities caused by stray whitespace or leading slashes. Reformatted code to be closer to PEP8. Updated tests to use Pytest. Fixed requirements.txt, which was missing the ``requests`` package.
@scnerd scnerd mentioned this issue Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtpdowns