Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying explicit multiple networks in LMF file leads to mkfs.lustre failure #197

Open
degremont opened this issue Feb 8, 2016 · 3 comments
Milestone

Comments

@degremont
Copy link
Collaborator

When we want to specify multiple lnets for a target in an explicit manner (by setting a network=lnet1,lnet2 in the LMF for example), mkfs.lustre does not handle corectly the generated "--network=lnet1,lnet2" command line set up by shine.
I'm aware this is more a bug at the mkfs.lustre level, but it can be easily worked around inside shine with
the following fix.

diff /usr/lib/python2.6/site-packages/Shine/Lustre/Actions/Format.py.sav /usr/lib/python2.6/site packages/Shine/Lustre/Actions/Format.py
143c143,144
<             command.append('--network=%s' %    self.comp.network)
---
>             for net in self.comp.network.split(','):
>                 command.append('--network=%s' % net)

Thanks.

Reported by: theryf

@degremont
Copy link
Collaborator Author

When you are specifying this 2 LNET networks, are you meaning this is a kind of double rails or you want to restrict the host to only 2 networks among more than that?

Is this compatible with the network matching code in the same function?

There is tests checking this behaviour in Lustre.Actions.CmdTest.ActionsTest.
This seems enough unclear to me that this requires at least one test to ensure everything is going smoothly.

Original comment by: degremont

@degremont
Copy link
Collaborator Author

Oh, good catch !
Sorry, I didn't notice the matching code above.
Indeed, I ought to have a look at it and the testcase you mention
in order to ensure this is working smoothly, or adjust it if not.

Original comment by: theryf

@degremont
Copy link
Collaborator Author

  • Milestone: 1.5 --> 1.6

Original comment by: degremont

@degremont degremont added this to the 1.6 milestone May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant