Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all the unused agreement pages and associated tests #1673

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Remove all the unused agreement pages and associated tests #1673

merged 2 commits into from
Sep 19, 2023

Conversation

smcmurtry
Copy link
Contributor

@smcmurtry smcmurtry commented Sep 19, 2023 •
edited
Loading

Summary | Résumé

Remove all the "signed in" unused agreement pages and associated tests. Clicking the link on these pages triggers a 500 error.

Test instructions | Instructions pour tester la modification

Reproduce the bug on staging

  1. log into staging as an admin
  2. visit https://staging.notification.cdssandbox.xyz/services/1dac916a-05b2-49ca-bf75-072231c3f505/agreement (or swap in any service id)
  3. click the link
  4. you get a 500 error

Verify the agreement pages are gone from the Review app

  1. log into the review app as an admin
  2. visit https://pqktbw65mgl5ka2ala466csiri0envjb.lambda-url.ca-central-1.on.aws/services/1dac916a-05b2-49ca-bf75-072231c3f505/agreement
  3. you should get a "page not found" error

@github-actions
Copy link

🧪 Review environment

https://pqktbw65mgl5ka2ala466csiri0envjb.lambda-url.ca-central-1.on.aws/

jzbahrai
jzbahrai approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jzbahrai jzbahrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@smcmurtry smcmurtry merged commit ce826f7 into main Sep 19, 2023
9 checks passed
@smcmurtry smcmurtry deleted the fix/remove-all-unused-agreement-pages branch September 19, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzbahrai jzbahrai jzbahrai approved these changes

Assignees

@andrewleith andrewleith

@jzbahrai jzbahrai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smcmurtry @jzbahrai @andrewleith