feat: allow free function exports in typewriter #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comcalvi
changed the title
…mcalvi/function-exports
Signed-off-by: github-actions <[email protected]>
mrgrain
reviewed
Oct 25, 2024
| @@ -411,11 +411,10 @@ export class TypeScriptRenderer extends Renderer { | |||
| throw new Error(`Symbol ${sym} (in ${sym.scope}) not visible from ${this.scopes[0]} (missing import?)`); | |||
| } | |||
|
|
|||
| protected renderFunction(func: CallableDeclaration) { | |||
| protected renderFunction(func: CallableDeclaration & TypeDeclaration) { | |||
There was a problem hiding this comment.
I don't think this is correct, we want to accept all CallableDeclarations not, just the ones that are also a TypeDeclaration.
There was a problem hiding this comment.
I think we keep the signature as it is.
Then w can have a guard isExported(x): is { exported: true } { ... } to check if exported exists and is true.
…-service-spec into comcalvi/function-exports
|
@aws-cdk/aws-service-spec: No model change detected |
…mcalvi/function-exports
mrgrain
reviewed
Oct 25, 2024
| /** | ||
| * Whether this type is being exported from its scope | ||
| */ | ||
| public get export() { |
There was a problem hiding this comment.
Now we have two things that do the same. I rather have 2 different interface.
Signed-off-by: github-actions <[email protected]>
mrgrain
reviewed
Oct 25, 2024
mrgrain
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typewriter does not allow free functions to be exported today. This PR enables exporting free functions.
Required for aws/aws-cdk#31850.