Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed rules cause poor highlighting on GitHub.com #21

Open
maxbrunsfeld opened this issue Apr 28, 2020 · 1 comment
Open

Malformed rules cause poor highlighting on GitHub.com #21

maxbrunsfeld opened this issue Apr 28, 2020 · 1 comment

Comments

@maxbrunsfeld
Copy link

These two rules contain a patterns property, but no end property:

These rules are not valid, because they cause the highlighter to push a new rule onto its stack which can never be popped off.

GitHub's engine used to allow this, but now it does not. See also textmate/textmate#1437.
@maxbrunsfeld maxbrunsfeld mentioned this issue Apr 28, 2020
Closed
4 tasks
@nwhetsell nwhetsell mentioned this issue Apr 29, 2020
Merged
@nwhetsell
Copy link
Contributor

@maxbrunsfeld Thanks for getting to the bottom of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxbrunsfeld @nwhetsell