Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues from dependency-checking on val computation #41

Open
joshuahhh opened this issue Dec 8, 2015 · 1 comment
Open

Comments

@joshuahhh
Copy link
Collaborator

Some diagrams which used to work OK now take dozens of seconds to load. Profiling suggests that > 90% of these diagrams' render time is spent in Attribute._value's call to Attribute.circularReferencePath, so I'm guessing this is #32's fault.

Example of a very slow drawing: Field.json.txt.

I'm not sure exactly what property of a drawing makes it susceptible to this slow-down. But the Field drawing has a large spread. It makes sense that not caching the circular-reference check would cause especially big problems for drawings like that.

@electronicwhisper
Copy link
Collaborator

Yeah, probably some caching would fix this.

"Nested" spreads in general are a little shakey performance-wise in my experience. By nested spreads I mean for example the 2D grid where both X is a spread and Y is an independent spread, requiring a cross-product of the two spreads. I am not sure if this is a result of the nesting or just a result of so many iterations. It would be interesting to test performance of a spread (0, 100) versus two "nested" spreads (0, 10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants