Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure due to backwards-incompatible aeson change #209

Closed
gelisam opened this issue Jan 17, 2022 · 1 comment · Fixed by #210
Closed

CI failure due to backwards-incompatible aeson change #209

gelisam opened this issue Jan 17, 2022 · 1 comment · Fixed by #210

Comments

@gelisam
Copy link
Collaborator

gelisam commented Jan 17, 2022

I believe the CI failures in #206 are not due to changes in my PR, but rather, to a backwards-incompatible aeson change (presumably the much publicized switch away from HashMap, due to the discovery of a collision attack).

I can reproduce this on master by running cabal update before cabal build, so this probably requires both publishing revisions with new upper bounds and updating HEAD to be compatible with aeson-2.x. And possibly some CPP magic to continue to be compatible with aeson-1.x.

@gelisam gelisam mentioned this issue Jan 17, 2022
@cdepillabout
Copy link
Owner

Thanks for bringing this up.

I published a revision for termonad-4.2.0.0 (the current latest version), that makes sure to put an upper bound on aeson: https://hackage.haskell.org/package/termonad-4.2.0.0/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants