Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() used with C++20 where it was removed #1138

Open
yurivict opened this issue May 27, 2024 · 0 comments

Comments

@yurivict
Copy link

yurivict commented May 27, 2024

Describe the bug
Build fails:

In file included from <built-in>:1:
In file included from /usr/ports/graphics/openmvs/work/.build/libs/MVS/CMakeFiles/MVS.dir/cmake_pch.hxx:5:
In file included from /usr/ports/graphics/openmvs/work/openMVS-2.3.0/libs/MVS/Common.h:42:
In file included from /usr/ports/graphics/openmvs/work/openMVS-2.3.0/libs/MVS/../Common/Common.h:176:
In file included from /usr/ports/graphics/openmvs/work/openMVS-2.3.0/libs/MVS/../Common/Types.h:76:
/usr/ports/graphics/openmvs/work/openMVS-2.3.0/libs/MVS/../Common/FastDelegateCPP11.h:155:61: error: no member named 'unique' in 'std::shared_ptr<void>'
  155 |         if ((sizeof(functor_type) > store_size_) || !store_.unique())
      |                                                      ~~~~~~ ^
1 error generated.

Please see the docs here showing that the unique() function is removed.

There is a similar issue #1075, but you somehow still keep producing releases where removed features are used.

You probably use gcc which isn't 100% C++ compliant and doesn't check for removed features.

You need to build with Clang which does find removed features usage.

Desktop (please complete the following information):

  • OS: FreeBSD
  • Version 2.3.0
@yurivict yurivict changed the title 2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() is used with C++20 where it was removed 2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() and std::unary_function are used with C++20 where it was removed May 27, 2024
@yurivict yurivict changed the title 2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() and std::unary_function are used with C++20 where it was removed 2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() are used with C++20 where it was removed May 27, 2024
@yurivict yurivict changed the title 2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() are used with C++20 where it was removed 2.3.0 is broken because the removed C++ feature std::shared_ptr::unique() used with C++20 where it was removed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant