Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

think out delete feature #48

Open
cch5ng opened this issue Mar 27, 2017 · 1 comment
Open

think out delete feature #48

cch5ng opened this issue Mar 27, 2017 · 1 comment

Comments

@cch5ng
Copy link
Owner

cch5ng commented Mar 27, 2017

should it have a confirmation option or undo option (after the deletion has executed)

  • undo is a bit more complex due to async nature of localForage/indexedDb functions

  • not even positive how you would track info to execute undo

    • does that mean that you would add a flag to each indexedDb entry (justDeleted: boolean)
    • there has to be some unique qualifier to know which entry to undo; and if deleted to know whether to display or not...
    • then to avoid clutter, over time, need to actual delete stuff that you can no longer undo
    • need to add a time limit to undo (like maybe a day? then need to store date deleted to compare to cur date and also the flag if entry eligible for undo)
  • make undo function as an enhancement for next version but it is a good problem to figure out in the long run...

@cch5ng
Copy link
Owner Author

cch5ng commented Mar 27, 2017

@cch5ng cch5ng mentioned this issue Mar 27, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant