reject non canonical encoding length. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Feb 19, 2024
spdmlib/src/crypto/x509v3.rs
Outdated
| length[i] = *b; | ||
| let length_byte0 = data[0]; | ||
| let (length, byte_comsumed) = match length_byte0 { | ||
| n if (n & 0x80) == 0 => (n as usize, 1), |
There was a problem hiding this comment.
please don't use hardcoded 0x80 or 0x81.
There was a problem hiding this comment.
please don't use hardcoded 0x80 or 0x81.
updated.
jyao1
reviewed
Feb 19, 2024
| @@ -25,7 +25,6 @@ const ASN1_TAG_SEQUENCE: u8 = | |||
| ASN1_TAG_CLASS_UNIVERSAL_MASK | ASN1_FORM_CONSTRUCTED_MASK | ASN1_TAG_NUMBER_SEQUENCE; | |||
| const ASN1_TAG_EXPLICIT_EXTENSION: u8 = 0xA3; | |||
| const ASN1_TAG_EXTN_VALUE: u8 = 0x04; | |||
| const ASN1_LENGTH_MULTI_OCTET_MASK: u8 = 0x80; | |||
There was a problem hiding this comment.
why remove it?
updated.
jyao1
reviewed
Feb 20, 2024
spdmlib/src/crypto/x509v3.rs
Outdated
| let length_byte0 = data[0]; | ||
| let (length, byte_comsumed) = match length_byte0 { | ||
| n if (n & ASN1_LENGTH_MULTI_OCTET_MASK) == 0 => (n as usize, 1), | ||
| one_octet if one_octet == ASN1_LENGTH_MULTI_OCTET_MASK + 1 => { |
There was a problem hiding this comment.
please define a new static variable.
There was a problem hiding this comment.
please define a new static variable.
updated.
jyao1
reviewed
Feb 20, 2024
spdmlib/src/crypto/x509v3.rs
Outdated
| } | ||
| Ok((usize::from_le_bytes(length), length_count as usize + 1)) | ||
| } | ||
| two_octet if two_octet == ASN1_LENGTH_MULTI_OCTET_MASK + 2 => { |
There was a problem hiding this comment.
please define a new static variable.
There was a problem hiding this comment.
please define a new static variable.
updated.
fix ccc-spdm-tools#28. Signed-off-by: Yang, Longlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #28.