Add configurable target support to build scripts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Prinz <[email protected]>
Signed-off-by: Timothy Prinz <[email protected]>
Signed-off-by: Timothy Prinz <[email protected]>
taprinz
commented
Feb 6, 2024
| @@ -203,16 +204,22 @@ run() { | |||
| CHECK_OPTION=false | |||
| BUILD_OPTION=false | |||
| RUN_OPTION=false | |||
| TARGET_OPTION=x86_64-unknown-none | |||
There was a problem hiding this comment.
Unsure if it's bad practice in shell scripts to define the variable later than a function may refer to it, like the build function above
jyao1
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial step to formalize some of the work I've done to get this working on riscv64 as per #10.
This change doesn't do much specifically for riscv64 support but allows the user to select the target for an SPDM-RS build. I've left the default as x86_64-unknown-none, since that's the only formally supported architecture at the moment.
The changes to pre_build.sh are because specific architectures might require specific patches. I had experimented with a riscv64 specific patch and expect one will be needed (as will specifics for other architectures if we ever want to support them). This also would allow an integrator to utilize the build scripts for any custom platforms they may want to add.