ignore unknown versions in version response. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longlongyang
force-pushed
the
ignoreversion13
branch
from
e0fc8e6 to
eb999f9
Compare
jyao1
reviewed
Jan 24, 2024
spdmlib/src/message/version.rs
Outdated
| break; | ||
| } | ||
| } else { | ||
| // for unknown versions, just ignore it! |
There was a problem hiding this comment.
I recommend we only ignore the higher version - 1.4, 2.0.
The unknown lower version - 0.0, 0.9, should be rejected.
There was a problem hiding this comment.
I recommend we only ignore the higher version - 1.4, 2.0. The unknown lower version - 0.0, 0.9, should be rejected.
updated.
Current design will reject version response if there is a version other than 0x10, 0x11 and 0x12. In this patch, will not reject such version response, instead, unknown versions will be ignored. Signed-off-by: Yang, Longlong <[email protected]>
longlongyang
force-pushed
the
ignoreversion13
branch
from
eb999f9 to
b2bbbf7
Compare
jyao1
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current design will reject version response if there is a version other than 0x10, 0x11 and 0x12. This patch make it accept such version response, instead, unknown versions will be ignored.