Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customized nonce for get measurement request. #115

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

longlongyang
Copy link
Collaborator

@longlongyang longlongyang commented Jul 31, 2024

Currently, the Nonce in get measurement is generated by get_random. This patch add a new paramenter spdm_nonce_struct to API send_receive_spdm_measurement to support customized Nonce.

Copy link
Collaborator

@xiaoyuxlu xiaoyuxlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not add a new function?

@longlongyang longlongyang force-pushed the nonce_get_measurement branch from 3ad4c6c to 97670b3 Compare August 1, 2024 08:11
@longlongyang
Copy link
Collaborator Author

why not add a new function?

updated.

Copy link
Collaborator

@xiaoyuxlu xiaoyuxlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


#[allow(clippy::too_many_arguments)]
#[maybe_async::maybe_async]
pub async fn send_receive_spdm_measurement_with_nonce(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please just change "send_receive_spdm_measurement()"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please just change "send_receive_spdm_measurement()"

Updated.

@longlongyang longlongyang force-pushed the nonce_get_measurement branch from 97670b3 to 3ad4c6c Compare August 1, 2024 09:42
@jyao1 jyao1 merged commit 76a6813 into ccc-spdm-tools:main Aug 1, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants