Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console logs are not preserved with redirect #29

Open
ccampbell opened this issue Jul 9, 2013 · 8 comments
Open

Console logs are not preserved with redirect #29

ccampbell opened this issue Jul 9, 2013 · 8 comments
Assignees

Comments

@ccampbell
Copy link
Owner

See #4 for additional information

There is a checkbox in the chrome dev tools Preserve log upon navigation, but people who have tried it have had mixed results.

@ghost ghost assigned ccampbell Jul 9, 2013
@schmod
Copy link
Contributor

schmod commented Jul 9, 2013

Swapping out onResponseStarted with onHeadersReceived seems to make 302, 303, 304, 204, and any other body-less responses work fine for me, as long as Preserve log upon navigation is enabled.

If I had to guess, I'd say that we probably had issues with onHeadersReceived because the event fires so early on. Now that we've got the code to deal with this same problem with onResonseStarted (#22, 6eb44d1), we can probably safely use onHeadersReceived instead.

I threw a few mangled/illegal HTTP responses (ie. a body-less 200) at the extension, and onHeadersReceived worked every time. onResonseStarted ironically works for malformed 302s and 303s (missing a Location header), but never worked for other body-less responses.

@ccampbell
Copy link
Owner Author

Sweet! I will push a new version later today then! I think you are right that the reason it wasn't working before was because of the race condition you fixed.

@marco-santamaria
Copy link

Hi, it seems that with the current PHP implementation (version 4.1.0) this issue persists.
Regards,
Marco

@cyberwolf
Copy link

Also encountering the same problem here. Any progress made on this one?

@kgustine
Copy link

This issue still exists with 4.1.0. Using PHP. Slim framework with Monolog's chromephphandler class. I am redirecting due to missing information. I can see the X-ChromeLogger-Data header on the 302 redirect response, but it is not captured (with Preserve log checked).

@mattzuba
Copy link

Just ran into this today, the issue is over a year old, is there any chance of it being fixed soon?

@togro
Copy link

togro commented Mar 4, 2016

Any news about this issue ?

@caffeinejolt
Copy link

Also hitting this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants