Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing all-in-one builds #12

Open
cburgmer opened this issue Oct 31, 2016 · 4 comments
Open

Stop publishing all-in-one builds #12

cburgmer opened this issue Oct 31, 2016 · 4 comments

Comments

@cburgmer
Copy link
Owner

Hey @barillax, in 2571b79 i've made a change to stop publishing the all-in-one packages. I just realised, that we only recently added the non-cssom one.

The benefits of not publishing those is removing the need to provide updates here if some downstream dependency changes. Naturally the user should just get those by running a local npm install.

Can you let me know if that works with your build process / otherwise whether we can come up with a good argument why we should bring back support for these?

@barillax
Copy link
Contributor

barillax commented Nov 2, 2016

Hey @cburgmer , thanks for checking!

So, I recall our original need for inlineresources.allinone.nocssom.js was that our build process didn't use browserify, and the existing allinone (which I presume the version located at https://wzrd.in/standalone/inlineresources@latest would be equivalent to) bundles in CSSOM, which breaks on minified stylesheets. If it weren't for that issue, the wzrd build would be sufficient!

The current version is working great for us, so in the worst case we could simply fork or pin to the current version. I don't want to make a lot of work for you if we're your only non-browserify/webpack user.

@cburgmer
Copy link
Owner Author

cburgmer commented Nov 2, 2016

That's fine, I'm just trying to strike a balance.

I'll sit down and think about what to do. Basically I want:

  1. No deps checked in, not even in a all-in-one distributable
  2. The library should be easy to include via UMD headers (for AMD, CommonJS and script inclusion), and should make it trivial to get its own dependencies included via old school <script> inclusions.
  3. Supports having deps optional.

This generally doesn't seem to be solved in the JS community. I've been reading around a lot, trying different things, but they all seem to cater to slightly different problems. In the end I might just build my own UMD header template on top.

I assume that work for you? In this case you would have to switch to getting hold of url and css-font-face-src as a dependency, which wzrd.in can also offer.

@barillax
Copy link
Contributor

barillax commented Nov 2, 2016

Since our pipeline is to effectively the same as the old school script include approach (namely: concat, uglify, and minify), I think that would work for us. Thanks!

I agree that things are a bit of a mess right now wrt to modules :-(

@cburgmer
Copy link
Owner Author

cburgmer commented Nov 5, 2016

  • Provide a way through npm to get hold of the url package with UMD header
  • Provide a UMD header version css-font-face-src dependency
  • Document dependencies in README

cburgmer added a commit that referenced this issue Jun 4, 2017
…r that"

Keep the bundle around for compatibility reasons, until we solve #12, and bump the major version.

This reverts commit 2571b79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants