Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New document] was broken #84

Open
cben opened this issue Apr 28, 2015 · 2 comments
Open

[New document] was broken #84

cben opened this issue Apr 28, 2015 · 2 comments
Labels
5 - Needs Test bug
Milestone
"beta"

Comments

@cben
Copy link
Owner

cben commented Apr 28, 2015

No description provided.

@cben
Copy link
Owner Author

cben commented Apr 28, 2015

This was (A) dumb bug I should have seen (B) has no tests (C) seriously broke stuff for ~5 days!

hot-fixed by 7c7d63c.

Not sure the window.newPad = newPad; fix is elegant; now that I have a server side, the right thing probably involves a server side redirect e.g. /new/ -> random, pointing href there (actually no, it must be a button with POST), and unobtrusively attaching .onclick = newPad or dropping it entirely.
[That's also a good time to stop using weak Math.random in browsers without strong random]

But first, tests.

@cben
Copy link
Owner Author

cben commented Apr 28, 2015

re POST: should consider what happens when running from local files.
For some reason googling didn't answer the simple question whether POST to a file:// URL works. Perhaps the question is too dumb.

@cben cben changed the title [New document] broken [New document] was broken May 19, 2015
@cben cben mentioned this issue May 19, 2015
Closed
@cben cben added this to the "beta" milestone Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Needs Test bug
Projects
None yet
Milestone
"beta"
Development

No branches or pull requests
1 participant
@cben