Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sACN universe list in discovery messages uses incorrect byte ordering #142

Open
alphajbravo opened this issue Jun 17, 2024 · 1 comment
Open
Assignees
Labels
bug Problems in the code

Comments

@alphajbravo
Copy link
Contributor

When constructing the universe list for an sACN discovery message, the universe numbers are not translated to the correct byte order for the protocol. It looks like memcpy is used to load the PDU data section, which skips the required htobe16 translation step.

memcpy(pdu.data.data, global_cfg.fd[fd].universe + page * 512, universes * sizeof(uint16_t));

@cbdevnet cbdevnet self-assigned this Jun 24, 2024
@cbdevnet cbdevnet added the bug Problems in the code label Jun 24, 2024
@cbdevnet
Copy link
Owner

Good catch, will try to find time to look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problems in the code
Projects
None yet
Development

No branches or pull requests

2 participants