Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform repository into catppuccin/code-icons #182

Open
sgoudham opened this issue Jun 6, 2024 · 5 comments
Open

Transform repository into catppuccin/code-icons #182

sgoudham opened this issue Jun 6, 2024 · 5 comments
Labels

Comments

@sgoudham
Copy link
Contributor

sgoudham commented Jun 6, 2024

Describe the feature

Based on previous discussion between contributors, we are interested in making this repository a "dumb" one by extracting out the extension logic into catppuccin/vscode and renaming this repository to catppuccin/code-icons.

This repository would then become a datastore for the code icons, most likely in multiple formats and sizes.

@sgoudham sgoudham added enhancement New feature or request meta and removed enhancement New feature or request labels Jun 6, 2024
@thelooter
Copy link
Contributor

Do we want to limit the repository to just code icons. I suggest going the route of providing different modules with different types of icons. That way a more general purpose iconset like fontawesome or nerdicons could develop over time

@sgoudham
Copy link
Contributor Author

sgoudham commented Jun 6, 2024

I remember having the same idea a while back but I ended up agreeing with Winston that people might just want to pull in code-icons as a submodule instead of one generic icons repository with all the assets.

We can have separate repositories, really not looking to introduce more monorepo-style repositories into Catppuccin xD (cc: @backwardspy)

@thelooter
Copy link
Contributor

thelooter commented Jun 6, 2024

I remember having the same idea a while back but I ended up agreeing with Winston that people might just want to pull in code-icons as a submodule instead of one generic icons repository with all the assets.

I agree, maybe an approach with multiple npm / jsr packages would make sense. I just think that having multiple repos for icons is more confusing than it helps with eliminating monorepos.

In the end I'm gonna follow the core team decision, just my insight into things

This approach would also allow for far easier icon updates via renovate, as npm packages are natively supported

@sgoudham
Copy link
Contributor Author

sgoudham commented Jun 6, 2024

The larger idea is to add a Contributing page onto the Catppuccin website that would list repositories / link to different resources in one place, which would aim to boost the visibility of all the resources developers have at their disposal.

Since we're using Astro, could probably be markdown pulled from the revamped contributing guide that I'm planning on doing for ctp/ctp. That was winston's original vision to make sure we're not repeating our documentation between website/GitHub. (But this is not a decision which has been thought out, just thinking out loud)

@sgoudham
Copy link
Contributor Author

sgoudham commented Jun 6, 2024

This approach would also allow for far easier icon updates via renovate, as npm packages are natively supported

We're already using Renovate across a bunch of repos and the idea to enable it for the entire organisation. Renovate monorepo support is actually not mature at all (at least from the consumer point / designing workflows pulling in things from monorepos.) I've been fighting with it for the last few weeks over catppuccin/toolbox haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants